feat(notifications): reenable notifications

[JPSchellenberg]

Hey,

I readded the notifications. This time they are invoked through the Notifications-reducer. They are not translated yet - I will add this in a different PR as it does not work with the i18n-system we are currently using.

[sr258]

The notifications are displayed for quite a long time. I think it would be good to make them dismissable or to decrease the timespan.

The list of notifications wil grow quite quickly and is cumbersome to maintain (and create) if they all have individual actions. Wouldn't it be better to have generic actions like this (each dispatchable with a message as argument):

• success
• error
• warning
• info

instead of:
export success
export error
html export success
html export error
...

[JPSchellenberg]

Yes, that would be the way through the actions.

We already have such action that can be dispatched: https://github.com/Lumieducation/Lumi/blob/feature/notifications/client/src/state/Notifications/NotificationsActions.ts#L11

It would look like this:

export function exportAsHtml(contentId: string): any {
    return async (dispatch: any) => {
        dispatch({
            payload: { contentId },
            type: H5PEDITOR_EXPORTHTML_REQUEST
        });

        try {
            await api.exportAsHtml(contentId);

            dispatch(notify('message', 'success'));

            dispatch({
                payload: { contentId },
                type: H5PEDITOR_EXPORTHTML_SUCCESS
            });
        } catch (error) {
            dispatch(notify('message', 'error'));

            dispatch({
                payload: { contentId },
                type: H5PEDITOR_EXPORTHTML_ERROR
            });
        }
    };
}

What do you think?

[sr258]

I see, so NotificationsReducer only listens to H5P_EXPORT_ERROR etc.? I wouldn't have expected to have these action types in the notification reducer but in some other place. The notifications redux stuff could be agnostic of the actual action types and the "relaying" could be done in a different place, but I'm not sure if we gain much from separating this at the moment.

[github-actions]

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀