Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Touch hit attempts before the early Perfect window #472

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

LumpBloom7
Copy link
Owner

@LumpBloom7 LumpBloom7 commented Aug 6, 2023

Ignore Touch hit attempts before the early Perfect window

Previously any non-miss results would've been counted as a perfect if it was made early. This is not really good as the hit windows of Touches are much larger than any other note type. Hopefully this would make it less likely that an accidental hit was made too early, which feels bad.

The "closing-in" animation of touches have been adjusted to only happen once it is possible to hit the Touch note.

This behavior also matches what maimaiDX does, so a plus in terms of maimai player expectation as well

@LumpBloom7 LumpBloom7 changed the title Make visualizer point inwards Ignore Touch hit attempts before the early Perfect window Aug 6, 2023
@LumpBloom7 LumpBloom7 merged commit 836ba31 into master Aug 16, 2023
3 checks passed
@LumpBloom7 LumpBloom7 deleted the Touch-Early-windows branch August 16, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant