Git icons and highlighting in Nvimtree

[Lun4m]

Is there a way to activate these two options in Nvim-tree? As far as I can tell they should be on by default in plain Lunarvim since

lvim.builtin.nvimtree.show_icons.git = 1
lvim.builtin.nvimtree.git_hl = 1

but I don't seem to get neither of the two to show up.

Here's my full config.lua:

-- general
lvim.format_on_save = true
lvim.lint_on_save = true
lvim.colorscheme = "gruvbox-flat"
vim.g.gruvbox_flat_style = "dark"
vim.cmd("set wrap") -- Wrap text if line longer than terminal lenght
-- QTconsole launch command
vim.cmd([[
command! -nargs=0 RunQtConsole call jobstart('jupyter qtconsole --JupyterWidget.include_other_output=True --JupyterQtConsoleApp.hide_menubar=True')")
let g:ipy_celldef = '^##'
]])

lvim.builtin.cmp.autocomplete = true
lvim.builtin.cmp.confirm_opts.select = false
lvim.builtin.autopairs.active = true

-- keymappings
lvim.leader = "space"
lvim.keys.normal_mode["<C-s>"] = ":w<cr>"

local _, actions = pcall(require, "telescope.actions")
lvim.builtin.telescope.defaults.mappings = {
    i = {
      ["<C-j>"] = actions.move_selection_next,
      ["<C-k>"] = actions.move_selection_previous,
      ["<C-n>"] = actions.cycle_history_next,
      ["<C-p>"] = actions.cycle_history_prev,
    },
    n = {
      ["<C-j>"] = actions.move_selection_next,
      ["<C-k>"] = actions.move_selection_previous
    }
}

-- After changing plugin config exit and reopen LunarVim, Run :PackerInstall :PackerCompile
lvim.builtin.dashboard.active = true
lvim.builtin.terminal.active = true
lvim.builtin.telescope.defaults.sorting_strategy = 'ascending'
lvim.builtin.nvimtree.setup.diagnostics.enable = false

-- if you don't want all the parsers change this to a table of the ones you want
lvim.builtin.treesitter.ensure_installed = "maintained"
lvim.builtin.treesitter.ignore_install = { "haskell" }
lvim.builtin.treesitter.highlight.enabled = true
lvim.lang.python.formatters = {
  {
    exe = "black",
    args = {}
  }
}
-- lvim.lang.tex.lsp.setup.build.on_save = true
-- lvim.lang.tex.build.on_save = true
-- lvim.lang.tex.forward_search.executable = "zathura"

-- LSP
lvim.lsp.diagnostics.virtual_text = false
lvim.lsp.automatic_servers_installation = false

-- Additional Plugins
lvim.plugins = {
  {"sindrets/diffview.nvim",
    event = "BufRead",
  },
  {"npxbr/glow.nvim", ft = {"markdown"}},
  {"ellisonleao/gruvbox.nvim"},
  {"eddyekofo94/gruvbox-flat.nvim"},
  {"lukas-reineke/indent-blankline.nvim",
    event = "BufRead",
    setup = function()
      vim.g.indentLine_enabled = 1
      vim.g.indent_blankline_char = "▏"
      vim.g.indent_blankline_filetype_exclude = {"help", "terminal", "dashboard", "NvimTree"}
      vim.g.indent_blankline_buftype_exclude = {"terminal"}
      vim.g.indent_blankline_show_trailing_blankline_indent = false
      vim.g.indent_blankline_show_first_indent_level = false
    end},
  {"ray-x/lsp_signature.nvim",
      config = function() require"lsp_signature".on_attach() end,
      event = "InsertEnter"
  },
  {"folke/lsp-colors.nvim",
    event = "BufRead",
  },
  {"rktjmp/lush.nvim"},
  {'dccsillag/magma-nvim', run = ':UpdateRemotePlugins'},
  {"norcalli/nvim-colorizer.lua",
      config = function() require"colorizer".setup() end},
  {"bfredl/nvim-ipy"},
  {"ethanholz/nvim-lastplace",
	event = "BufRead",
	config = function()
		require("nvim-lastplace").setup({
			lastplace_ignore_buftype = { "quickfix", "nofile", "help" },
			lastplace_ignore_filetype = {
				"gitcommit", "gitrebase", "svn", "hgcommit",
			},
			lastplace_open_folds = true,
		})
	end,
  },
  {"felipec/vim-sanegx", event = "BufRead"},
  {"arthurxavierx/vim-unicoder"},
  {"lervag/vimtex",
  config = function()
    vim.g.vimtex_compiler_method = "latexmk"
    vim.g.vimtex_view_method = "zathura"
    vim.g.vimtex_quickfix_mode = 0
    -- vim.cmd("set conceallevel=2")
    -- vim.g.tex_conceal='abdmg'
    vim.cmd("call vimtex#init()")
  end}
}

-- Additional Leader bindings for WhichKey
lvim.builtin.which_key.mappings["j"] = {
  name = "Nvim-IPy",
  o = {"<cmd>IPython<cr>", "Run IPython inside nvim"},
  p = {"<cmd>RunQtConsole<cr>", "Run python QTconsole"},
  k = {"<cmd>IPython --existing --no-window<cr>", "Connect to existing kernel"},
  c = {"<Plug>(IPy-RunCell)", "Run current cell"},
  a = {"<Plug>(IPy-RunAll)", "Run all cells"},
}
lvim.builtin.which_key.mappings["r"] = {
  name = "Magma",
  l = {"<cmd>MagmaEvaluateLine<CR>", "Run current line"},
  p = {"<cmd>MagmaInit python3<CR>", "Initialize python3 kernel"},
  c = {"<cmd>MagmaReevaluateCell<CR>", "Run current cell"},
  o = {"<cmd>MagmaShowOutput<CR>", "Show output"},
  v = {"<cmd>MagmaEvaluateVisual<CR>", "Run current visual selection"},
}
lvim.builtin.which_key.mappings["d"] = {
  name = "DiffView",
  c = {"<cmd>DiffviewClose<CR>", "Close Diffview"},
  o = {"<cmd>DiffviewOpen<CR>", "Open Diffview"},
  f = {"<cmd>DiffviewToggleFiles<CR>", "Toggle files while in Diffview"},
}

-- Lualine conf
lvim.builtin.lualine.sections.lualine_a = {"mode"}
lvim.builtin.lualine.sections.lualine_y = {"location", "progress"}

[kylo252]

Seems to be because they have not moved to the setup function just yet, so these are in the wrong section

LunarVim/lua/lvim/core/nvimtree.lua

Lines 33 to 39 in f8a34fa

	show_icons = {
	git = 1,
	folders = 1,
	files = 1,
	folder_arrows = 1,
	tree_width = 30,
	},

[Lun4m]

Oh, ok! So should I open a new issue or is this discussion good enough for keeping track of the problem?