chore(breadcrumbs): remove Markdown from excluded file types
#3196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls fix conflicts |
Nefendi
force-pushed
the
remove-dead-markdown-entry-in-breadcrumbs-ignore-file-types-list
branch
from
cdd6be4
to
f71595b
Compare
|
done |
|
BTW, I have initially marked this PR as a draft because that is what
|
The output of `vim.bo-filetype` for Markdown files is 'markdown' not 'Markdown' so this entry did nothing.
Nefendi
force-pushed
the
remove-dead-markdown-entry-in-breadcrumbs-ignore-file-types-list
branch
from
f71595b
to
7ab5ba1
Compare
cpea2506
changed the title
Markdown from excluded file types
|
@ChristianChiarulli I think it's now okay to be merged |
|
but it's pointed at rolling |
My bad, fixed it. 😅 |
ChristianChiarulli
approved these changes
Nov 21, 2022
|
Thanks 🚀 |
Nefendi
deleted the
remove-dead-markdown-entry-in-breadcrumbs-ignore-file-types-list
branch
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Nov 23, 2022
* upstream/master: chore: bump plugins version (LunarVim#3506) docs: github pull request template update (LunarVim#3512) fix(uninstaller): correct a sentence in help (LunarVim#3511) fix(uninstaller): add separate flag to remove user config (LunarVim#3508) chore: bump plugins version (LunarVim#3483) chore(breadcrumbs): remove `Markdown` from excluded file types (LunarVim#3196) chore: update docker branch to latest release for "Try it first" (LunarVim#3500) fix: discard invalid choice when closing buffers (LunarVim#3488) fix(nvimtree): avoid hard-coded mapping (LunarVim#3492) fix(autocmds): remove spell autocmd (LunarVim#3487) fix(lsp): sumneko-lua library scanning (LunarVim#3484)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Markdownentry in the list of excluded file types for the breadcrumbs module did nothing, as the output ofvim.bo.filetypefor MD files yields the value ofmarkdown.How Has This Been Tested?
No tests other than the simple smoke ones were necessary.
Additional remarks
This PR addresses the discussion in #3189.