Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): sumneko-lua library scanning #3484

Merged
merged 2 commits into from Nov 17, 2022
Merged

fix(lsp): sumneko-lua library scanning #3484

merged 2 commits into from Nov 17, 2022

Conversation

carsakiller
Copy link
Contributor

Description

  • Enables busted and luassert libraries by default to prevent popup every time
  • Enables checkThirdParty

fixes #3439

How Has This Been Tested?

  • Tested in VS Code, confirmed no issues and very minimal startup time increase (~22ms)

Currently unable to test in LunarVim, but it would be my first time using it anyway, so bad behaviour would be hard to catch.

Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@kylo252 kylo252 merged commit 88b1144 into LunarVim:master Nov 17, 2022
@carsakiller carsakiller deleted the fix-lsp-sumneko-libraries branch November 18, 2022 03:25
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Nov 23, 2022
* upstream/master:
  chore: bump plugins version (LunarVim#3506)
  docs: github pull request template update (LunarVim#3512)
  fix(uninstaller): correct a sentence in help (LunarVim#3511)
  fix(uninstaller): add separate flag to remove user config (LunarVim#3508)
  chore: bump plugins version (LunarVim#3483)
  chore(breadcrumbs): remove `Markdown` from excluded file types (LunarVim#3196)
  chore: update docker branch to latest release for "Try it first" (LunarVim#3500)
  fix: discard invalid choice when closing buffers (LunarVim#3488)
  fix(nvimtree): avoid hard-coded mapping (LunarVim#3492)
  fix(autocmds): remove spell autocmd (LunarVim#3487)
  fix(lsp): sumneko-lua library scanning (LunarVim#3484)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annoying popup when editing Lua files
2 participants