fix: Remove J and K key mappings for move #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the J and K key mappings for moving lines of code since the J mapping overrides the standard J (join lines) action. A-j and A-k are still available for moving lines.
|
I agree @kylo252 what do you think? |
|
+1 on this PR, I have these disabled in my config, I also prefer to remove jk and any other mappings for esc as well, they are very confusing |
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Oct 14, 2022
* upstream/rolling: (50 commits) fix: name treesitter source in cmp (LunarVim#3223) fix(breadcrumbs): make sure winbar_filetype_exclude is customizable (LunarVim#3221) fix: typo in git.lua fix: Remove J and K key mappings for move (LunarVim#3206) fix(lua-dev): make sure we are loading the correct types (LunarVim#3208) chore: bump nvim-tree.lua version to `b01e7be` (LunarVim#3203) chore(illuminate): pcall for configure fix(plugins): set max jobs to 50 on mac feat(uninstaller): desktop entry Feat(installer): desktop entry (LunarVim#3187) fix(lualine): globalstatus=true by default fix: use function for pickers feat(cmp): add configs for cmp.setup.cmdline (LunarVim#3180) fix(typo): fix language server name typo in config example LunarVim#3176 (LunarVim#3183) feat: warn user when setting un-installed colorscheme (LunarVim#2982) fix: move telescope.actions pcall to the top fix(installer): don't set log level fix(lualine): guard setup on install (LunarVim#3185) fix: telescope delete_buffer binds correct scope Add: Workflow to stale/close inactive issues | Fixes LunarVim#3168 (LunarVim#3177) ...
tomazursic
pushed a commit
to tomazursic/LunarVim
that referenced
this pull request
Oct 19, 2022
* upstream/master: (139 commits) chore: update changelog feat(config): allow disabling reload-on-save (LunarVim#3261) fix: nil table in breadcrumbs in autocommand (LunarVim#3267) docs: Update contributing readme with new url for install docs. (LunarVim#3254) fix: disable unsupported asian characters spellchecking (LunarVim#3259) fix: copilot background should matcha statusline fix: disable gitsigns hunk navigation message (LunarVim#3244) chore(plugins): bump version (LunarVim#3248) perf(plugins): move assert `vim.env.LVIM_DEV_MODE` logic (LunarVim#3238) fix(nvim-cmp-lsp): update_capabilities has been deprecated (LunarVim#3245) fix(luadev): this plugin has been renamed (LunarVim#3235) fix: don't install desktop file w/o xdg-desktop-menu (LunarVim#3229) fix(alpha): check alpha module (LunarVim#3233) feat: latest impatient updates from upstream (LunarVim#3236) fix: name treesitter source in cmp (LunarVim#3223) fix(breadcrumbs): make sure winbar_filetype_exclude is customizable (LunarVim#3221) fix: typo in git.lua fix: Remove J and K key mappings for move (LunarVim#3206) fix(lua-dev): make sure we are loading the correct types (LunarVim#3208) chore: bump nvim-tree.lua version to `b01e7be` (LunarVim#3203) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the J and K key mappings for moving lines of code since the J mapping overrides the standard J (join lines) action.
Not having the standard J mapping is confusing for new users. Alt-j and Alt-k are still available for moving lines.
How Has This Been Tested?