Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable unsupported asian characters spellchecking #3259

Merged
merged 1 commit into from Oct 16, 2022

Conversation

jakubreron
Copy link
Contributor

Description

VIM algorithm does not support spellchecking for Asian characters, but they are spellchecked by default anyway, which results in every sentence highlighted as wrong when you use multiple languages in your file.

Before the change:
all Asian characters are spellchecked and, as a result, underlined
image

After the change:
they are omitted from spellchecking
image

How Has This Been Tested?

  • Open an empty buffer
  • Paste a few Japanese/Chinese sentences
こんにちは、LunarVimは素晴らしいです
お疲れ様でした

This is a correct English sentence.

VIMの日本語のスペルチェックは不可能です
  • set the language spelling :set spelllang=en
  • all Asian characters are highlighted as errors
  • append the cjk to disable Asian characters spell checking set spelllang+=cjk
  • now everything is correct

@abzcoding abzcoding merged commit 7715900 into LunarVim:rolling Oct 16, 2022
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Oct 17, 2022
* upstream/rolling:
  fix: nil table in breadcrumbs in autocommand (LunarVim#3267)
  docs: Update contributing readme with new url for install docs. (LunarVim#3254)
  fix: disable unsupported asian characters spellchecking (LunarVim#3259)
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Oct 19, 2022
* upstream/master: (139 commits)
  chore: update changelog
  feat(config): allow disabling reload-on-save (LunarVim#3261)
  fix: nil table in breadcrumbs in autocommand (LunarVim#3267)
  docs: Update contributing readme with new url for install docs. (LunarVim#3254)
  fix: disable unsupported asian characters spellchecking (LunarVim#3259)
  fix: copilot background should matcha statusline
  fix: disable gitsigns hunk navigation message (LunarVim#3244)
  chore(plugins): bump version (LunarVim#3248)
  perf(plugins): move assert `vim.env.LVIM_DEV_MODE` logic (LunarVim#3238)
  fix(nvim-cmp-lsp): update_capabilities has been deprecated (LunarVim#3245)
  fix(luadev): this plugin has been renamed (LunarVim#3235)
  fix: don't install desktop file w/o xdg-desktop-menu (LunarVim#3229)
  fix(alpha): check alpha module (LunarVim#3233)
  feat: latest impatient updates from upstream (LunarVim#3236)
  fix: name treesitter source in cmp (LunarVim#3223)
  fix(breadcrumbs): make sure winbar_filetype_exclude is customizable (LunarVim#3221)
  fix: typo in git.lua
  fix: Remove J and K key mappings for move (LunarVim#3206)
  fix(lua-dev): make sure we are loading the correct types (LunarVim#3208)
  chore: bump nvim-tree.lua version to `b01e7be` (LunarVim#3203)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants