Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icons): make devicons optional #3616

Merged
merged 3 commits into from
Jan 13, 2023

Conversation

LostNeophyte
Copy link
Member

@LostNeophyte LostNeophyte commented Dec 15, 2022

Description

we were requiring nvim-web-devicons in a couple places without checking if it's available or if icons are enabled

Fixes #3640

How Has This Been Tested?

  1. lvim.use_icons = false
  2. :PackerSync
  3. no more errors in lir and breadcrumbs

@LostNeophyte
Copy link
Member Author

LostNeophyte commented Dec 15, 2022

the ci failed not because of this pr, it also did in my other pr, something's wrong with it commit sha for tokyonight in snapshots is incorrect

Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Might have to learn Lua so next time I can contribute a fix myself 😉

@jsjoeio
Copy link

jsjoeio commented Dec 15, 2022

Hmm...I wonder why it's having issues verifying plugins:

Verifying core plugins
mismatch at [tokyonight.nvim]: expected [0f7b6a5], got [ecae454]
Error: : Unable to verify plugins, make sure to manually run ':PackerSync' when starting lvim for the first time.
packer.nvim: Error running config for telescope.nvim: ...r/.local/share/lunarvim/lvim/lua/lvim/core/telescope.lua:127: attempt to concatenate field 'theme' (a nil value)

Any ideas?

@LostNeophyte
Copy link
Member Author

Hmm...I wonder why it's having issues verifying plugins:

Verifying core plugins
mismatch at [tokyonight.nvim]: expected [0f7b6a5], got [ecae454]
Error: : Unable to verify plugins, make sure to manually run ':PackerSync' when starting lvim for the first time.
packer.nvim: Error running config for telescope.nvim: ...r/.local/share/lunarvim/lvim/lua/lvim/core/telescope.lua:127: attempt to concatenate field 'theme' (a nil value)

Any ideas?

If you take a look at folke/tokyonight.nvim@0f7b6a5 it says This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository, it may be it

@LostNeophyte
Copy link
Member Author

PackerSync also fails on new installs with tokyonight

Copy link
Contributor

@opalmay opalmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this onto master so that checks pass with the recent lir setup change

@LostNeophyte LostNeophyte merged commit 3115088 into LunarVim:master Jan 13, 2023
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Jan 13, 2023
* upstream/master:
  fix(lir): nil check, simpler logic (LunarVim#3725)
  fix(icons): make devicons optional (LunarVim#3616)
  feat(dap-ui): update setup table (LunarVim#3724)
  refactor(quit)!: use native quit confirm (LunarVim#3721)
  fix(config): copy the correct example config (LunarVim#3722)
  feat: cmdline config option enables cmp-cmdline plugin (LunarVim#3719)
  refactor: move to upstream lir (LunarVim#3711)
  fix(treesitter): prepend to rtp (LunarVim#3708)
  refactor: migrate to lazy.nvim (LunarVim#3647)
  fix: bash installer errors (LunarVim#3686)
  refactor(treesitter)!: use auto-install by default (LunarVim#3677)
  fix(telescope): backwards compability (LunarVim#3596)
  feat: enable auto preview colorscheme by default (LunarVim#3701)
  fix(ts): disable indent for c and cpp (LunarVim#3687)
  chore: update funding
  feat: update setup tables (LunarVim#3693)
  refactor: use lir fork in the org (LunarVim#3694)
  chore: bump plugins version (LunarVim#3652)
@LostNeophyte LostNeophyte deleted the fix/make-devicons-optional branch June 13, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disabling icons is crashing the application
4 participants