-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icons): make devicons optional #3616
fix(icons): make devicons optional #3616
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Might have to learn Lua so next time I can contribute a fix myself 😉
Hmm...I wonder why it's having issues verifying plugins: Verifying core plugins
mismatch at [tokyonight.nvim]: expected [0f7b6a5], got [ecae454]
Error: : Unable to verify plugins, make sure to manually run ':PackerSync' when starting lvim for the first time.
packer.nvim: Error running config for telescope.nvim: ...r/.local/share/lunarvim/lvim/lua/lvim/core/telescope.lua:127: attempt to concatenate field 'theme' (a nil value) Any ideas? |
If you take a look at folke/tokyonight.nvim@0f7b6a5 it says |
PackerSync also fails on new installs with tokyonight |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this onto master so that checks pass with the recent lir setup change
3be02d7
to
613771b
Compare
* upstream/master: fix(lir): nil check, simpler logic (LunarVim#3725) fix(icons): make devicons optional (LunarVim#3616) feat(dap-ui): update setup table (LunarVim#3724) refactor(quit)!: use native quit confirm (LunarVim#3721) fix(config): copy the correct example config (LunarVim#3722) feat: cmdline config option enables cmp-cmdline plugin (LunarVim#3719) refactor: move to upstream lir (LunarVim#3711) fix(treesitter): prepend to rtp (LunarVim#3708) refactor: migrate to lazy.nvim (LunarVim#3647) fix: bash installer errors (LunarVim#3686) refactor(treesitter)!: use auto-install by default (LunarVim#3677) fix(telescope): backwards compability (LunarVim#3596) feat: enable auto preview colorscheme by default (LunarVim#3701) fix(ts): disable indent for c and cpp (LunarVim#3687) chore: update funding feat: update setup tables (LunarVim#3693) refactor: use lir fork in the org (LunarVim#3694) chore: bump plugins version (LunarVim#3652)
Description
we were requiring
nvim-web-devicons
in a couple places without checking if it's available or if icons are enabledFixes #3640
How Has This Been Tested?
lvim.use_icons = false
:PackerSync