Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cmdline config option enables cmp-cmdline plugin #3719

Merged
merged 3 commits into from Jan 13, 2023

Conversation

opalmay
Copy link
Contributor

@opalmay opalmay commented Jan 13, 2023

We already have the configuration for cmdline completions (disabled by default). But the plugin has to be installed as a user plugin after enabling it.
With this commit setting lvim.builtin.cmp.cmdline.enable = true will also enable the cmp-cmdline plugin.

@opalmay opalmay changed the title feat: automatically enable cmp-cmdline when setting setup option feat: automatically enable cmp-cmdline when enabling config option Jan 13, 2023
Copy link
Member

@LostNeophyte LostNeophyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@opalmay opalmay changed the title feat: automatically enable cmp-cmdline when enabling config option feat: automatically enable cmp-cmdline plugin when enabling config option Jan 13, 2023
@opalmay opalmay changed the title feat: automatically enable cmp-cmdline plugin when enabling config option feat: enable cmp-cmdline plugin when enabling config option Jan 13, 2023
@opalmay opalmay changed the title feat: enable cmp-cmdline plugin when enabling config option feat: cmdline config option will also enable the cmp-cmdline plugin Jan 13, 2023
@opalmay opalmay changed the title feat: cmdline config option will also enable the cmp-cmdline plugin feat: cmdline config option also enables cmp-cmdline plugin Jan 13, 2023
@opalmay opalmay changed the title feat: cmdline config option also enables cmp-cmdline plugin feat: cmdline config option enables cmp-cmdline plugin Jan 13, 2023
@opalmay opalmay merged commit 8cc1cc6 into master Jan 13, 2023
@opalmay opalmay deleted the feat-cmp-cmdline branch January 13, 2023 10:32
tomazursic pushed a commit to tomazursic/LunarVim that referenced this pull request Jan 13, 2023
* upstream/master:
  fix(lir): nil check, simpler logic (LunarVim#3725)
  fix(icons): make devicons optional (LunarVim#3616)
  feat(dap-ui): update setup table (LunarVim#3724)
  refactor(quit)!: use native quit confirm (LunarVim#3721)
  fix(config): copy the correct example config (LunarVim#3722)
  feat: cmdline config option enables cmp-cmdline plugin (LunarVim#3719)
  refactor: move to upstream lir (LunarVim#3711)
  fix(treesitter): prepend to rtp (LunarVim#3708)
  refactor: migrate to lazy.nvim (LunarVim#3647)
  fix: bash installer errors (LunarVim#3686)
  refactor(treesitter)!: use auto-install by default (LunarVim#3677)
  fix(telescope): backwards compability (LunarVim#3596)
  feat: enable auto preview colorscheme by default (LunarVim#3701)
  fix(ts): disable indent for c and cpp (LunarVim#3687)
  chore: update funding
  feat: update setup tables (LunarVim#3693)
  refactor: use lir fork in the org (LunarVim#3694)
  chore: bump plugins version (LunarVim#3652)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants