Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seekbar controls feature #72

Closed

Conversation

esegebart
Copy link
Contributor

Added skip forward and skip backward icons to move 15 seconds ahead or back.
Changed the rewind and fast forward buttons to continuously skip upon pressing. Each press increase the speed of rewind or fast forward up to 4X.

Elyse Segebart and others added 13 commits February 6, 2023 11:01
[+] Install unmet peer deps
[+] babel/core, babel preset env, types rn 0.63.17
[+] Remove types/react-native
[+] Would like to add progress indicators 1x 2x 3x etc
[+] Need to change the first press to just jump forward 15 sec once
[+] Clean up console logs
[+] Add button controls for skips
[+] Add images for skip button
@esegebart
Copy link
Contributor Author

@LunatiqueCoder The last commit will be necessary to try it out. I had also forgotten to remove an import so it will break without last commit. :)

@LunatiqueCoder
Copy link
Owner

Ok, I'll try to have a look this weekend. Really happy that you mananged to sort it out!

@esegebart
Copy link
Contributor Author

esegebart commented Aug 11, 2023 via email

Elyse Segebart and others added 3 commits August 12, 2023 11:52
[+] added white icons
[+] renamed seek icons to more meaningful names
[+] removed rewind style
@LunatiqueCoder
Copy link
Owner

@esegebart Ok, this looks good actually, but of course it can be improved. And It just came to my mind a very good idea. Although I have 1 question:

Do you plan to have both type of buttons for your project? Or do you want to keep the ones you created only? Because I think that #37 will enable you to extract your logic outside of the package and pass it as props (onPressRewind, icon, etc), meaning that everyone will be able to customise to an extended level.

@esegebart
Copy link
Contributor Author

esegebart commented Aug 13, 2023

@LunatiqueCoder Hey! I'm so glad you like it 🤩 So in my case, yes, I will be using both. Some of my broadcasts are 12 hours long so I need to be able to allow the user to get to a game that starts at 8 hours in quickly, while also letting them go back 15 seconds to rewatch a play made by a player. In the future, this my not be necessary because the cameras will know when a new game starts. But I was just trying to figure out how to separate those concerns between skipping and rewind/fast forwarding. And voila! Two buttons :) Did you try the continuous rewind/FF up to 4x? I actually discovered how to do it by accident. 😂 It would be nice to have a little indicator how fast they are at but yeah! Super glad to hear it looks good! Of course yes it can improve, the onEnd needs to happen when it reaches the end of the video while rewind/FF, the icons could be a little crisper, indicator of rw/FF speed on buttons, code a little cleaner. Overall, I am so proud of the progress I've made in the last few months that was able to make this actually do what I wanted! :) Skillz improving 🤩

Elyse Segebart added 5 commits August 14, 2023 16:52
[+] Rename the icon file to use 3x
[+] Styling of icons to make them even
[+] Props had a B instead of a b in it
[+] Update all disableSeekBar
[+] Remove the equal sign from rw ff
@LunatiqueCoder
Copy link
Owner

Hey @esegebart. Does this work on your side? I tried it on iOS and it's going a little bit crazy 🥲

@esegebart
Copy link
Contributor Author

esegebart commented Sep 21, 2023 via email

@LunatiqueCoder
Copy link
Owner

@esegebart I'm so sorry but the package changed so much lately, I am not sure that we can use those changes anymore. I think we should try again after we implement #37. I'll close this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants