Update Arabic language definition #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix word character range to exclude punctuation Update split sentence exceptions Add additional dictionaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I edited the file manually instead of generating with the script (since I'm running Lute with docker so couldn't use the python command in the README), but it passes the verify files test.
There might be too many dictionaries now, but I didn't want to remove any of the existing ones since I wasn't the one who added them (personally I find the 3 I added and Google translate to be most useful).
Also, the reason for all the extra query parameters with livingarabic is to disable searching example sentences in the filter options. Having it enabled usually, clutters the results with loads of unrelated words, so I thought for most people it makes sense to have it disabled as the default.