Use the input dtype and device for the output in rascaline-torch #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All calculations still happen on CPU with 64-bit floats, but the data is automatically converted on input and output as required.
|
Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping |
frostedoyster
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All calculations still happen on CPU with 64-bit floats, but the data is automatically converted on input and output as required.
Should help with metatensor/metatrain#58
📚 Documentation preview 📚: https://rascaline--278.org.readthedocs.build/en/278/