Fixed a problem in BIDIRCPU with camera PDF

LuxCoreRender · Jun 10, 2019 · 8e3e8b7 · 8e3e8b7
1 parent 4327166
commit 8e3e8b7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/release-notes.txt b/release-notes.txt
@@ -79,6 +79,7 @@
 * Fixed the access to an uninitialized variable in ProjectionLight::Preprocess()
 * Fixed a crash when trying to render a scene without light sources with PATHOCL (issue #202)
 * Fixed DLSC to work with Front and back material transparency (aka light invisible object)
+* Fixed a problem in BIDIRCPU with camera PDF
 
 Check https://wiki.luxcorerender.org/LuxCoreRender_Release_Notes for the full list
 of release notes.

diff --git a/src/slg/engines/bidircpu/bidircputhread.cpp b/src/slg/engines/bidircpu/bidircputhread.cpp
@@ -189,12 +189,7 @@ void BiDirCPURenderThread::ConnectToEye(const float time,
 				const float cosToCamera = Dot(lightVertex.bsdf.hitPoint.shadeN, -eyeDir);
 				const float cameraPdfW = scene->camera->GetPDF(eyeDir, filmX, filmY);
 				const float cameraPdfA = PdfWtoA(cameraPdfW, eyeDistance, cosToCamera);
-				// Was:
-				//  const float fluxToRadianceFactor = cameraPdfA;
-				//
-				// but now BSDF::Evaluate() follows LuxRender habit to return the
-				// result multiplied by cosThetaToLight
-				const float fluxToRadianceFactor = cameraPdfW / (eyeDistance * eyeDistance);
+				const float fluxToRadianceFactor = cameraPdfA;
 
 				const float weightLight = MIS(cameraPdfA) *
 					(misVmWeightFactor + lightVertex.dVCM + lightVertex.dVC * MIS(bsdfRevPdfW));