This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Nextprev improvements #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also prefetch the previous photo. Add custom fallback prefetching code if HTML5 prefetch not supported.
Delay the prefetching until the current image has finished loading.
This was referenced Jul 15, 2019
ildyria
suggested changes
Jul 15, 2019
| if (current2x) { | ||
| // If the currently displayed image uses the 2x variant, | ||
| // chances are that so will the next one. | ||
| href = preloadPhoto.medium2x |
There was a problem hiding this comment.
Yes and no. I think you still need to check if medium2x is not empty.
There was a problem hiding this comment.
Is that not covered on line 161?
ildyria
approved these changes
Jul 15, 2019
| if (current2x) { | ||
| // If the currently displayed image uses the 2x variant, | ||
| // chances are that so will the next one. | ||
| href = preloadPhoto.medium2x |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129.
The display of the thumbnail in the photo view while the larger-resolution image is being loaded is implemented using CSS background image (on the
<img>object, no less). It actually looks pretty cool, I think.Image prefetching code was extended to request both previous and next images. The prefetch request is initiated only after the main image has finished loading. We no longer prefetch movie files. There's now a fallback for browsers that don't support HTML5
link rel=prefetch. While the fallback was trivial, detecting whether it's needed was not. I thought I would be forced to hardcode it based on the user agent, but in the end I found some code that's supposed to detect it at run time.Code was also extended in places to handle the case of previous or next image being empty, to fully support non-wraparound feature being added to the server.