Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to disable first/last wraparound #306

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Jul 15, 2019

Trivial PR providing a configurable option to disable photo wraparound on first/last picture. It's off by default to match the current behavior.

I was actually surprised to find out that this was implemented on the server side rather than in the front end but in the end it made for an easier implementation, so no complaints. 馃槂

Note that this shouldn't go in without LycheeOrg/Lychee-front#130 because some extra code on the front end is needed to gracefully handle missing prev/next.

@kamil4 kamil4 requested a review from ildyria July 15, 2019 03:40
@codecov-io
Copy link

Codecov Report

Merging #306 into master will increase coverage by 0.21%.
The diff coverage is 100%.

Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@kamil4 kamil4 merged commit 1df1e18 into master Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the nextprev-improvements branch July 15, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants