After upgrade v3 -> v4, Diagnostics page is no longer available.

[peppla]

Detailed description of the problem [REQUIRED]

I executed the upgrade steps from diagnostics page, after the upgrade an error page appeared telling me to run
composer install --no-dev

Steps to reproduce the issue

Steps to reproduce the behavior:

1. Perform upgrade steps (I think version was 4.03, but I don't know it for sure.)
2. After the upgrade follow instructions to install composer
3. Diagnose page stops working with "Server Error or Api not found"
4. See error*

Screenshots
No screenshots

Output of the diagnostics [REQUIRED]

[root@appserver1 Lychee]# php artisan lychee:diagnostics


Diagnostics
-----------
Info: Latest version of PHP is 7.4
Warning: You may experience problems when uploading a large amount of photos. Take a look in the FAQ for details.
Warning: Dropbox import not working. dropbox_key is empty.
Warning: Image optimizer enabled but cwebp not found!
Warning: Image optimizer enabled but gifsicle not found!
Warning: Image optimizer enabled but jpegoptim not found!
Warning: Image optimizer enabled but optipng not found!
Warning: Image optimizer enabled but pngquant not found!
Warning: Image optimizer enabled but svgo not found!

System Information
------------------
Lychee Version (git):            master (d08f2ee) - Up to date (48 minutes ago).
DB Version:                      4.0.6

composer install:                --no-dev
APP_ENV:                         local
APP_DEBUG:                       true

System:                          Linux
PHP Version:                     7.3
Max uploaded file size:          40M
Max post size:                   100M
MySQL Version:                   8.0.15

Imagick:                         1
Imagick Active:                  1
Imagick Version:                 1691
GD Version:                      2.3.0


In DiagnosticsController.php line 87:

  Argument 2 passed to App\Http\Controllers\DiagnosticsController::line() must be of the type string, null given, called in /va
  r/www/Lychee/app/Http/Controllers/DiagnosticsController.php on line 253

Browser and system

MacOSX and Safari

[ildyria]

One of the value field in your config table is null instead of "" (empty string). I don't know why though.

[ildyria]

Error coming most likely from here would be my guess: https://github.com/LycheeOrg/Lychee/blob/master/database/migrations/2018_08_10_134924_move_settings.php#L61
Do you have null values in your previous installation (config) ?

[peppla]

Thanks.

mysql> select id,`key` from configs where value is null;
+----+-------------------+
| id | key               |
+----+-------------------+
| 32 | landing_subtitle  |
| 33 | landing_facebook  |
| 34 | landing_flickr    |
| 35 | landing_twitter   |
| 36 | landing_instagram |
| 37 | landing_youtube   |
+----+-------------------+
6 rows in set (0,00 sec)

Fixed.