Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #708 - Add a few failsafe #709

Merged
merged 2 commits into from Sep 1, 2020
Merged

fix #708 - Add a few failsafe #709

merged 2 commits into from Sep 1, 2020

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 1, 2020

fixes #708

@codecov
Copy link

codecov bot commented Sep 1, 2020 •
edited

Codecov Report

Merging #709 into master will increase coverage by 0.48%.
The diff coverage is 100.00%.

@ildyria ildyria requested a review from d7415 September 1, 2020 07:52
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria ildyria merged commit 55d9dac into master Sep 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-708 branch September 1, 2020 10:26
Aleshus pushed a commit to Aleshus/Lychee that referenced this pull request Sep 3, 2020
@ildyria @Aleshus
fix LycheeOrg#708 - Add a few failsafe (LycheeOrg#709)
bb3c8e7 
* fix LycheeOrg#708 
* add tests coverage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After upgrade v3 -> v4, Diagnostics page is no longer available.
2 participants
@ildyria @d7415