Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to version 4.4.0 + remove unnecessary php-intl requirement #1157

Merged
merged 2 commits into from
Dec 3, 2021

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Dec 3, 2021

No description provided.

@@ -49,7 +44,7 @@ public function check(array &$errors): void
}

// Extensions
$extensions = ['session', 'exif', 'mbstring', 'gd', 'PDO', 'json', 'zip', 'intl'];
$extensions = ['session', 'exif', 'mbstring', 'gd', 'PDO', 'json', 'zip'];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this become unnecessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was removed from the Laravel required package for installation.

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #1157 (6633668) into master (5cf7a06) will decrease coverage by 1.16%.
The diff coverage is 33.33%.

@sonarcloud
Copy link

sonarcloud bot commented Dec 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria ildyria merged commit fd35b72 into master Dec 3, 2021
@ildyria ildyria deleted the finalize-php8 branch December 3, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants