Files getting deleted if compression fails

[Giorgio-Germani]

Describe the bug
The Software deletes images, when compression fails.

Software version
Caesium Image Compressor 2.0.0 rc1

Operating System information
WIN 11

To Reproduce
Steps to reproduce the behavior:
Compress attached files with Caesium 2.0.0. RC1

Expected behavior
Failed compression should be listed, but original file should remain in folder.

Screenshots

Application Log
If you can, please provide your application log. The location of the file depends on your platform, but they usually are:

[2022-05-06 12:01:29.106][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:29.107][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:29.264][I] Usage report sent successfully
[2022-05-06 12:01:31.260][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:31.261][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:33.484][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:33.484][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:36.056][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:36.056][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:36.193][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:36.193][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:39.478][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:39.479][W] QPainter::restore: Unbalanced save/restore
[2022-05-06 12:01:39.487][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/11_360x500.jpg" to "D:/Georg/Pictures/Art/tatoos/11_360x500.jpg" (:0, )
[2022-05-06 12:01:39.498][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/10_571x500.jpg" to "D:/Georg/Pictures/Art/tatoos/10_571x500.jpg" (:0, )
[2022-05-06 12:01:39.525][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/12_360x500.jpg" to "D:/Georg/Pictures/Art/tatoos/12_360x500.jpg" (:0, )
[2022-05-06 12:01:39.527][C] Failed to copy from "D:/Georg/Pictures/Art/sketches/imsedfhsrgtjg.jpg" to "D:/Georg/Pictures/Art/sketches/imsedfhsrgtjg.jpg" (:0, )
[2022-05-06 12:01:39.537][C] Failed to copy from "D:/Georg/Pictures/Art/sketches/im4g.jpg" to "D:/Georg/Pictures/Art/sketches/im4g.jpg" (:0, )
[2022-05-06 12:01:39.538][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/13_360x500.jpg" to "D:/Georg/Pictures/Art/tatoos/13_360x500.jpg" (:0, )
[2022-05-06 12:01:39.570][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/5_167x500.jpg" to "D:/Georg/Pictures/Art/tatoos/5_167x500.jpg" (:0, )
[2022-05-06 12:01:39.571][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/4_263x500.jpg" to "D:/Georg/Pictures/Art/tatoos/4_263x500.jpg" (:0, )
[2022-05-06 12:01:39.613][C] Failed to copy from "D:/Georg/Pictures/Art/tatoos/8_585x500.jpg" to "D:/Georg/Pictures/Art/tatoos/8_585x500.jpg" (:0, )
[2022-05-06 12:01:39.618][C] Failed to copy from "D:/Georg/Pictures/Art/sketches/imwg.jpg" to "D:/Georg/Pictures/Art/sketches/imwg.jpg" (:0, )
[2022-05-06 12:01:39.623][I] Compression canceled by user.
[2022-05-06 12:01:39.624][I] Compression ended successfully.
Total images: 17
Uncompressed size: "396.42 KB"
Compressed size: "394.90 KB"
Elapsed time: 179 ms

Additional context
I attached the restored original files for testing.
tatoos.zip

[Lymphatus]

Seems like you're trying to compress images in place, right? Caesium creates a temp file and tries to overwrite the original, but the copy is failing. I'll investigate, thanks!

[Giorgio-Germani]

Yes indeed. I just want to overwrite the original ones.

[IlluminatiWave]

I just lost more than 10,000 images because of this bug. XD

[Lymphatus]

Found the reason: if you try to overwrite the original file and the compressed is bigger, the compression fails and the original file gets deleted. I'm going to fix it asap as this is a critical bug.

[Asgatlat]

could you release the fix ?
this bug is terrible (i know that using a RC is at our own risk)

[Lymphatus]

I have a fix on b27a397. I think I can make a rc.2 release in the next couple of days.

[Lymphatus]

RC.2 released, should be fixed - make a backup save just to be extra sure before giving a try.