Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary if statement and fix libcaesium error #210

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Remove unnecessary if statement and fix libcaesium error #210

merged 5 commits into from
Jun 21, 2023

Conversation

4G3NT
Copy link
Contributor

@4G3NT 4G3NT commented Jun 20, 2023

caesium-image-compressor: error while loading shared libraries: libcaesium.so: cannot open shared object file: No such file or directory

Install target doesn't copy libcaesium.so to the install prefix and symlinks it to /usr/lib/libcaesium.so, thus causing Caesium Image Compressor to fail to locate it.

@4G3NT
Copy link
Contributor Author

4G3NT commented Jun 20, 2023

If you have a more efficient way of doing this, please make a suggestion and I will apply it.

@Lymphatus
Copy link
Owner

I think it may break if you already have libcaesium in you lib path. If you look at #199 the goal here was to be able to build if you already had the library on your own. So maybe it's better check if already it's there before symlinking.

@4G3NT
Copy link
Contributor Author

4G3NT commented Jun 20, 2023

I tested it by having the Caesium Image Compressor already installed and with a dead symlink /usr/lib/libcaesium.so -> /usr/local/lib, and it worked fine. Can you test it yourself and see if that's the case?

@4G3NT
Copy link
Contributor Author

4G3NT commented Jun 20, 2023

image

before and after installation

@Lymphatus
Copy link
Owner

Lymphatus commented Jun 21, 2023

Seems ok to me, but I would just wrap the part where you install libcaesium in a IF (NOT LIBCAESIUM).
If someone has already a libcaesium installation I'd rather not mess with it and leave as it is.

@Lymphatus Lymphatus merged commit aaed844 into Lymphatus:main Jun 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants