Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable sampling #80

Merged
merged 6 commits into from
Jan 1, 2022
Merged

Add configurable sampling #80

merged 6 commits into from
Jan 1, 2022

Conversation

Lyr3x
Copy link
Owner

@Lyr3x Lyr3x commented Dec 31, 2021

Make sampling configurable with a default of 2. This is another configuration change:

roode:
  id: roode_platform
  i2c_address: 0x29
  update_interval: 10ms
  # roi:
    # roi_height: 16
    # roi_width: 6
  calibration:
    max_threshold_percentage: 85
    min_threshold_percentage: 5
    roi_calibration: true
    # sensor_offset_calibration: 8
    # sensor_xtalk_calibration: 53406
  # manual:
  #   sensor_mode: 3
  #   manual_threshold: 1280
  #   timing_budget: 200
  sampling:
    active: true
    size: 3
  invert_direction: true
  restore_values: false

@Lyr3x Lyr3x added this to the v1.4.1 milestone Dec 31, 2021
@CarsonF
Copy link
Collaborator

CarsonF commented Dec 31, 2021

Is active really needed? can the off value just be 1?

@Lyr3x
Copy link
Owner Author

Lyr3x commented Jan 1, 2022

Thanks @CarsonF! I removed the activeattribute. You can configure it now as

sampling: 3
or
sampling:
    size: 3

@Lyr3x Lyr3x merged commit 35d75c0 into master Jan 1, 2022
@Lyr3x Lyr3x deleted the configurable-sampling branch January 1, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants