Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Encoder does not throw error when passed boolean or NaN for dictionary #39

Closed
1 task done
M-Scott-Lassiter opened this issue May 14, 2022 · 1 comment
Closed
1 task done
Assignees
Labels
bug Something isn't working released

Comments

@M-Scott-Lassiter
Copy link
Owner

Contact Details

No response

What happened?

Passing values true, false, or NaN do not throw errors, and they should. Discovered during testing on another project using AlphanumericEncoder as a dependency.

Version

v1.5

What operating system are you seeing the problem on?

Windows

What version of Node are you seeing the problem on?

16

Relevant log output

No response

Are you able/willing to make the change? (It's ok if you're not!)

Yes

Code of Conduct

@M-Scott-Lassiter M-Scott-Lassiter added the bug Something isn't working label May 14, 2022
@M-Scott-Lassiter M-Scott-Lassiter self-assigned this May 14, 2022
github-actions bot pushed a commit that referenced this issue May 14, 2022
### [1.5.1](v1.5.0...v1.5.1) (2022-05-14)

### 🐞 Bug Fixes

* improve dictionary type checking ([3f37616](3f37616)), closes [#39](#39)
@M-Scott-Lassiter
Copy link
Owner Author

🎉 This issue has been resolved in version 1.5.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

No branches or pull requests

1 participant