[Bug]: Can pass bad dictionary values in constructor

[M-Scott-Lassiter]

Contact Details

No response

What happened?

Although #39 fixed the issue with bad values when setting encoder.dictionary, I discovered these bad values could still get passed in the constructor function. This was because the function looked to see if the value was truthy or not:

        if (configOptions.allowLowerCaseDictionary) {
            this.allowLowerCaseDictionary = configOptions.allowLowerCaseDictionary
        }
        if (configOptions.dictionary) {
            this.dictionary = configOptions.dictionary
        }

Changing the code to make it look for if that property is contained or not should fix the issue.

        if ('allowLowerCaseDictionary' in configOptions) {
            this.allowLowerCaseDictionary = configOptions.allowLowerCaseDictionary
        }
        if ('dictionary' in configOptions) {
            this.dictionary = configOptions.dictionary
        }

Version

v1.5.1

What operating system are you seeing the problem on?

Windows

What version of Node are you seeing the problem on?

16

Relevant log output

No response

Are you able/willing to make the change? (It's ok if you're not!)

Yes

Code of Conduct

• I agree to follow this project's Code of Conduct

[M-Scott-Lassiter]

🎉 This issue has been resolved in version 1.5.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀