Fix bug that caused issues in constructor function #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he constructor
Although directly setting bad dictionary values (e.g. `encoder.dictionary = null`) would throw an
error, using the constructor did not (e.g. `encoder = new AlphanumericEncoder( { dictionary: null }
)` ). This was due to the manner in which the constructor was checking to see if these optional
values were passed or not. This patch corrects that unintended behavior.
Resolves: #41
…or fix Resolves: #41
M-Scott-Lassiter
changed the title
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix behavior that allowed bad dictionary values to make it through if passed in the constructor function.
Pull Request Checklist
Please check if your PR fulfills the following requirements:
npm run build) locally and pushed all changesIssues Addressed: #41
Other Information
None