Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected pin string construction from JPasswordField contents #45

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

resoli
Copy link
Contributor

@resoli resoli commented Jan 4, 2023

In the initial loop on the various JPasswordField in MainFrame.abbinaCie(), getPassword() do not return the 1 character string content of the field, but a char[]. Adding it to the in-construction pin string implicitly calls toString[] on the char[], which results in a textual representation of it, something like this: [C@27716f4.
Here we propose passing the String.valueOf() of the char[] to the in-construction pin string.

@M0Rf30 M0Rf30 merged commit 8374478 into M0Rf30:podofo-vanilla Jan 4, 2023
@M0Rf30
Copy link
Owner

M0Rf30 commented Jan 4, 2023

thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants