Skip to content

Commit

Permalink
fix typo
Browse files Browse the repository at this point in the history
  • Loading branch information
@M4dmartig4n
M4dmartig4n committed Sep 18, 2019
1 parent f1b27e4 commit ed4fcaf
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion install_prereq.sh
View file
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ sudo apt-get update
sudo apt-get upgrade -y
sudo apt-get install -y dnsmasq hostapd screen curl python3-pip python3-setuptools python3-wheel mosquitto haveged net-tools

sudo pip3 install paho-mqtt pyaes tornado git+https://github.com/M4dmartig4n/sslpsk.gi
sudo pip3 install paho-mqtt pyaes tornado git+https://github.com/M4dmartig4n/sslpsk.git

echo "Ready to start upgrade"

5 comments on commit ed4fcaf

@digiblur
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far!

I tried a couple devices and see this in the web log...

Traceback (most recent call last):
  File "/usr/local/lib/python3.5/dist-packages/tornado/web.py", line 1697, in _execute
    result = method(*self.path_args, **self.path_kwargs)
  File "./fake-registration-server.py", line 115, in post
    os.system("./trigger_upgrade.sh %s &" % str(gwId))
UnboundLocalError: local variable 'gwId' referenced before assignment

@kueblc
Copy link

@kueblc kueblc commented on ed4fcaf Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an easy one, declare gwId as global at the start of the function

@kueblc
Copy link

@kueblc kueblc commented on ed4fcaf Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or move it back to .active as in https://github.com/ct-Open-Source/tuya-convert/blob/9b0e36d3f56dbb88dbb7a4b966e9d68d03c5feac/scripts/fake-registration-server.py#L75

@digiblur
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will give it a shot with my minor set of hack it together with Google python skills.

@M4dmartig4n
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems my cleanup before commit/push was too harsh

Please sign in to comment.