Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to select a column from a 2D dataset #7

Closed
1 task done
chuckwondo opened this issue Sep 23, 2022 · 1 comment
Closed
1 task done

Allow user to select a column from a 2D dataset #7

chuckwondo opened this issue Sep 23, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@chuckwondo
Copy link
Collaborator

chuckwondo commented Sep 23, 2022

Currently, a user may select only 1D datasets (e.g., quality_flag, sensitivity, etc.), but there are cases where a user may wish to select a column (or multiple columns) from a 2D dataset within a granule file (.h5).

For example, a user might wish to select rh100, but the file might contain a 2D dataset named rh with many columns, so specifying rh100 should select rh[100] (i.e., the column at index 100 [0-based index, thus 101st column]) as a 1D "dataset" from the 2D dataset named rh.

Note that the granule files in some collections may already contain rh100 (for example) as a 1D dataset, while files in other collections may not. Unfortunately, this is inconsistent.

However, a user should have a consistent experience without having to know whether or not the column the user wants to select is a 1D dataset or a column within a 2D dataset. In either case, the user should be able to specify, for example, rh100 and get either the 1D dataset that is already within the file, or the column at index 100 from the 2D rh dataset, if no such 1D dataset already exists. In either case, the user simply specifies rh100.

Further, the user may specify as many such datasets as desired (e.g., rh20, rh50, rh100) and the algorithm will do the "right thing" to get the data (either pull existing 1D datasets by the specified names, or pull the corresponding columns from the corresponding 2D dataset).

More specifically, when a user specifies a dataset with a name of the form <NAME><INTEGER>, the algorithm will first attempt to select a 1D dataset with the name <NAME><INTEGER>. If not found, the algorithm will look for a 2D dataset with the name <NAME>, and extract the column at index (0-based) <INTEGER>.

Acceptance Criteria

  • when a user specifies a column (dataset) name of the form <NAME><INTEGER>, the algorithm will first attempt to select a 1D dataset with the name <NAME><INTEGER>. If not found, the algorithm will look for a 2D dataset with the name <NAME>, and extract the column at index (0-based) <INTEGER>
@chuckwondo chuckwondo added the enhancement New feature or request label Sep 23, 2022
@chuckwondo chuckwondo transferred this issue from MAAP-Project/maap-documentation-examples Oct 15, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
chuckwondo added a commit that referenced this issue Oct 24, 2022
@chuckwondo
Copy link
Collaborator Author

Addressed by #16

chuckwondo added a commit that referenced this issue Oct 31, 2022
jjfrench added a commit that referenced this issue Nov 14, 2022
* feat(algorithm_inputs): Added 'doi' to algorithm inputs which users can specify

* chore(algorithm_inputs): Remove defaults, simplify process

* test: remove outdated doi conftest

* docs: Updated for DOI algorithm input

* feat: DOI algorithm input

* chore: Pull Request changes

* chore: minor PR changes

* docs: Updated for optional query input parameter

* test: Updated for optional query input parameter

* feat: Query input parameter now optional

* docs: Clarifying inputs

* feat: select columns from 2D datasets (#16)

Fixes: #5, #7

* fix: skip granule files that cannot be opened (#18)

Granule files that cannot be successfully read are skipped, rather than
causing job failure.  Offending files are retained to facilitate
analysis.

Fixes #17

* feat: lat lon algorithm inputs (#20)

* docs: lat/lon algorithm inputs additions

* test: lat/lon algorithm inputs additions

* feat: lat/lon algorithm inputs additions

* feat: support L1B and L2B collections (#21)

Fixes #19

* Prepare for 0.3.0 release

* Prepare for further development

* feat: user input to filter beams (#26)

* docs: User-supplied beams specification

* test: Testing various beams input

* feat: User-specified beams

* docs: updated beams documentation

* test: simple beams fail test

* test: check_beams_option

* docs: additional docstring changes

* test: additional tests ...

* fix: n_expected algorithm inputs (#27)

* fix: n_expected algorithm inputs (#33)

* chore: Release 0.4.0 (#28)

* chore: Release 0.4.0

* chore: minor changes for next release

* docs: changes for 0.4.0 release

* chore: Release 0.4.0

Co-authored-by: Chuck Daniels <chuck@developmentseed.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant