Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Succeed even when subset is empty #83

Merged
merged 10 commits into from
Jul 10, 2024
Merged

Conversation

chuckwondo
Copy link
Collaborator

Fixes #79

@chuckwondo chuckwondo requested a review from jjfrench July 3, 2024 23:20
src/gedi_subset/subset.py Outdated Show resolved Hide resolved
@chuckwondo chuckwondo force-pushed the issue79-succeed-empty-subset branch from 49a0e08 to b0e86a9 Compare July 8, 2024 21:58
@chuckwondo chuckwondo requested a review from jjfrench July 9, 2024 19:58
@chuckwondo
Copy link
Collaborator Author

@jjfrench, I added distinguishing messaging, and also managed to remove just a bit more usage of the returns library (so I'm incrementally chipping away at #3)

Copy link
Collaborator

@jjfrench jjfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good! Thanks for making that change!

@chuckwondo chuckwondo merged commit 3b28c68 into main Jul 10, 2024
2 checks passed
@chuckwondo chuckwondo deleted the issue79-succeed-empty-subset branch July 10, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not fail on empty subset
2 participants