Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vtnerd/Lee Clagett 2024 Q1/Q2 month 3 completion notes #31

Closed
vtnerd opened this issue Jul 10, 2024 · 0 comments
Closed

vtnerd/Lee Clagett 2024 Q1/Q2 month 3 completion notes #31

vtnerd opened this issue Jul 10, 2024 · 0 comments

Comments

@vtnerd
Copy link

vtnerd commented Jul 10, 2024

The bulk of time was spent on a (still in progress) LWS-frontend api (now called lwsf), and testing the LWS remote scanning feature.

I restarted the lwsf project after hearing about the demise of wallet2 in the main monero repo. woodser et al were updating wallet2 to work with LWS again, which (at the current moment) looks like a wasted effort. The lwsf project mirrors the wallet2_api.h but adds C++ smart pointers to the API. I will also start an initiative to update the upstream API with smart pointers, because the current approach leaks in certain circumstances (exceptions), and probably has unsafe deletes on shared raw pointers.

The LWS remote scanning feature underwent a lot of testing to see if it was actually faster given the extra burdens on ZMQ and LMDB (each worker thread adds ZMQ and LMDB write calls). There appeared to be some scaling benefits, and I posted about them in the PR. I don't have much code for this (just some code to fill up a LWS database with dummy accounts), so unfortunately everyone will just have to trust me that I did this work.

I also had many bug fixes to LWS. This took a good chunk of time - finding, unit testing, and fixing the bugs.

I worked on several fixes/updates for the main monero repo. My two serialization replacement PRs were updated, my P2P SSL patch was updated, my LMDB fixes were updated - see bottom of linked pages to see the updates to this month. I also had two new ZMQ fixes - fixed TX pruning and fixed DaemonInfo serialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants