Fix several bugs: #119
Merged
Fix several bugs: #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* lws::account height update should only go up. * Webhook confirmations can start after first new block * Webhook confirmations could face a rescan
|
Added some more tests, and fixed another issue within the DB scan height (it previously wasn't an issue until changes in the |
vtnerd
added a commit
that referenced
this pull request
Jun 3, 2024
* lws::account height update should only go up. * Webhook confirmations can start after first new block * Webhook confirmations could face a rescan
vtnerd
added a commit
that referenced
this pull request
Jun 4, 2024
* lws::account height update should only go up. * Webhook confirmations can start after first new block * Webhook confirmations could face a rescan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found these issues while digging deeper in the remote scanning code (although not related to that code). This will get merged relatively soon as these bugs need to be back-ported to release branch.