-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read interface for new serialization system #8970
base: master
Are you sure you want to change the base?
Conversation
What will |
|
@jeffro256 Earlier I mentioned protobuf, and I forgot completely that this interface cannot support reading of protobuf arrays (without some modifications to the interface). Write support should be possible (although I haven't tried to implement it yet). I've otherwise implemented reading/writing of everything else protobuf. I think its better to introduce the necessary changes when/if protobuf is added as potential format. A couple of people have asked for it years ago, but its pointless unless we can auto-generate schemas from this interface (another thing I failed to figure out - at least yet). Otherwise, epee_binary, json, msgpack are all implemented completely, and CBOR should be possible as well. Reading Protobuf ArraysReading protobuf arrays is difficult because a field within an object appears multiple times, and does not have to be contiguous. The binary format looks something like:
which specifies an integer array of length 2: |
9525ad4
to
510010c
Compare
@jeffro256 I finally updated this PR. I thought it was done previously, but I didn't merge in the requested changes for the read interface. Changes:
|
This is the read interface for my proposed serialization system, along with the remainder of the (major) adapters/wrappers that were not in the write interface review. After this review are the implementations (epee, json, msgpack), and then the changes needed to the existing code.