Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to suppress deprecation warnings in html report #302

Closed
jlwdl opened this issue Feb 24, 2022 · 2 comments · Fixed by #303
Closed

Add option to suppress deprecation warnings in html report #302

jlwdl opened this issue Feb 24, 2022 · 2 comments · Fixed by #303

Comments

@jlwdl
Copy link

jlwdl commented Feb 24, 2022

Description of Problem:

When generating the html report, a lot of deprecation warnings are present

Overview of the Solution:

One possible solution is to add an argument to the generate_report function of the SmartExplainer class, to give the option to suppress these warnings with this snippet:

`
import warnings

warnings.filterwarnings("ignore", category=DeprecationWarning)
`

@ThomasBouche
Copy link
Collaborator

Hi,
Thank you for your issue, indeed, these warnings are not necessary for the user of the report.
I add an ignore warning

We will do a minor release of Shapash in the next days or weeks

@jlwdl
Copy link
Author

jlwdl commented Feb 25, 2022

Hi,

thanks for the quick reply!

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants