-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added categories on admin page #345
Conversation
# Conflicts: # faq/admin.py # faq/forms.py # faq/templates/faq/admin_question_list.html # faq/views.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice overall! Left a few comments below 😄
I plan to use the next meetings to abstract the admin_x_list files, but first I pushed the simple changes. |
Codecov Report
@@ Coverage Diff @@
## dev #345 +/- ##
==========================================
+ Coverage 83.53% 83.86% +0.33%
==========================================
Files 118 118
Lines 3795 3862 +67
==========================================
+ Hits 3170 3239 +69
+ Misses 625 623 -2
Continue to review full report at Codecov.
|
…-admin # Conflicts: # faq/templates/faq/admin_question_list.html # faq/urls.py # faq/views.py # locale/nb/LC_MESSAGES/django.mo # locale/nb/LC_MESSAGES/django.po
Also reordered some of the views' fields.
This was for consistency, as the styling made the title have a slightly larger bottom margin than most other admin pages.
The new code utilizes more of the built-in classes in Fomantic-UI.
This fixes the bug that made them look like they were "extended" without having clicked any of the accordion elements.
The FAQ page is now also not listing categories with no questions.
This partly reverts 613b1e3.
They now lead to their respective admin list pages, instead of the FAQ admin panel.
6631e22
to
0ae0d1f
Compare
Added a transitional menu to choose between admin panel and editing categories or questions