Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some improvements to the member list #604

Merged
merged 8 commits into from
Mar 5, 2023
Merged

Some improvements to the member list #604

merged 8 commits into from
Mar 5, 2023

Conversation

ddabble
Copy link
Member

@ddabble ddabble commented Mar 5, 2023

Proposed changes

New features

Improvements

  • Made it possible to search for all member fields in the member list - not just the ones visible in the list (37aa420)
  • Improved translation of the quit/retired error messages (8769f9c)

Fixes

  • Fixed missing card numbers being displayed as "None" instead of simply showing a blank field, in the member list (80942a2)

Other changes

  • Moved constance first in the Django admin app list (d9ecf6a)

Areas to review closely

Check that the search bar on the member list page does indeed search for all (interesting) fields.

Deployment notes

Should set proper values for the ENROLL_MEMBERS_GUIDE_LINK, RETIRE_MEMBERS_GUIDE_LINK and QUIT_MEMBERS_GUIDE_LINK settings (through https://admin.makentnu.no/constance/config/ - after these changes have been deployed).

Checklist

(If any of the points are not relevant, mark them as checked)

  • Created tests that fail without the changes, if relevant/possible
  • Made sure that your code conforms to the code style guides and that any common code smells have been addressed
    • (It's not intended that you read through this whole document, but that you get yourself an overview over its contents, and that you keep it in mind while taking a second look at your code before opening a pull request)
  • Added sufficient documentation - e.g. as docstrings or in the README, if suitable
  • Added your changes to the "Unreleased" section of the changelog - mainly the changes that are of particular interest to users and/or developers, if any
  • Added a "Deployment notes" section above, if anything out of the ordinary should be done when deploying these changes to the server

@ddabble
Added links to member guides in the member list
711430d 
--- DEPLOYMENT NOTES ---
Should update `local_settings.py` with actual values for the
`ENROLL_MEMBERS_GUIDE_LINK`, `RETIRE_MEMBERS_GUIDE_LINK` and `QUIT_MEMBERS_GUIDE_LINK` settings.
@ddabble
Improved code for cleaning member search terms
1232f86 
...i.e. trimming whitespace and making it lowercase.
@ddabble
Search for all member fields in the member list
37aa420
@ddabble
Improved translation of quit/retired error messages
8769f9c
@ddabble
Fixed members' card number displayed as "None"
80942a2 
...instead of just the empty string, which is what all the other member fields are displayed as when missing a value.
@ddabble
Moved member guide links to constance config
1d0b623 
This will make it easier to potentially change the values of those settings.

--- DEPLOYMENT NOTES ---
[Replaces the deployment notes in 711430d]
Should set proper values for the
`ENROLL_MEMBERS_GUIDE_LINK`, `RETIRE_MEMBERS_GUIDE_LINK` and `QUIT_MEMBERS_GUIDE_LINK` settings
(through https://admin.makentnu.no/constance/config/).
@ddabble
Moved constance first in Django admin app list
d9ecf6a 
The dynamic settings will probably be visited the most often.
@ddabble
Updated CHANGELOG for #604
791cb07
@ddabble
Copy link
Member Author

ddabble commented Mar 5, 2023

Merging without explicit approval from another member, as the Dev committee agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker.

@ddabble ddabble merged commit ccbef09 into dev Mar 5, 2023
@ddabble ddabble deleted the fix/member-list-improvements branch March 5, 2023 19:33
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 5, 2023
View reviewed changes
internal/templates/internal/member_add.html

{% block extra_pre_content %}
<h3>
<a href="{{ config.ENROLL_MEMBERS_GUIDE_LINK }}" target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
internal/templates/internal/member_list.html
{% translate "TODOs when a member retires" %} <i class="external alternate icon"></i>
</a>
<br/>
<a href="{{ config.QUIT_MEMBERS_GUIDE_LINK }}" target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
internal/templates/internal/member_list.html
{% translate "TODOs when a new member enrolls" %} <i class="external alternate icon"></i>
</a>
<br/>
<a href="{{ config.RETIRE_MEMBERS_GUIDE_LINK }}" target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
internal/templates/internal/member_list.html
@@ -25,10 +25,26 @@
{% endif %}
</h1>

{% if perms.internal.add_member or perms.internal.change_member %}
<p>
<a href="{{ config.ENROLL_MEMBERS_GUIDE_LINK }}" target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
internal/templates/internal/member_quit.html

{% block extra_pre_content %}
<h3>
<a href="{{ config.QUIT_MEMBERS_GUIDE_LINK }}" target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
internal/templates/internal/member_retire.html

{% block extra_pre_content %}
<h3>
<a href="{{ config.RETIRE_MEMBERS_GUIDE_LINK }}" target="_blank">

Check warning

Code scanning / CodeQL

Potentially unsafe external link

External links without noopener/noreferrer are a potential security risk.
@ddabble ddabble mentioned this pull request Mar 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
web
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ddabble