Rename various things #648
Conversation
Including some changes that also change semantics in minor ways: * [CONTRIBUTING.md] Replaced the examples with the custom path converters previously removed in a5eaf62 * [profile_detail.html] The script tags in `extra_head` are now only rendered if the user has the `internal.is_internal` permission, as they're only used for code in `profile_detail_internal.html` anyway * [internal/models.py] Removed the TODO comment and created an issue for it instead (#643) * [admin_event_detail.html + admin_event_ticket_list.html] Added missing `font-size` styling, to make the titles match the ones in the other admin panel pages
Also switched out the "Add new quota" button for a green plus button, like most of the other admin panel pages.
Also renamed some CSS and JavaScript files to match the changed name of their templates.
Also renamed its `front_page` path to `index_page`.
Codecov Report
@@ Coverage Diff @@
## dev #648 +/- ##
==========================================
+ Coverage 87.38% 87.39% +0.01%
==========================================
Files 135 135
Lines 5714 5719 +5
==========================================
+ Hits 4993 4998 +5
Misses 721 721
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| {% url 'front_page' as front_page_url %} | ||
| <a href="{% get_absolute_uri_for_path request front_page_url %}" target="_blank"> | ||
| {% url 'index_page' as index_page_url %} | ||
| <a href="{% get_absolute_uri_for_path request index_page_url %}" target="_blank"> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link
| {{ ticket.timeplace.event.title }}: | ||
| {{ ticket.timeplace.start_time.date }} | ||
| </a> | ||
| {% else %} | ||
| <a href="{% url 'event_ticket_list' ticket.event.pk %}" target="_blank"> | ||
| <a href="{% url 'admin_event_ticket_list' ticket.event.pk %}" target="_blank"> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link
| @@ -19,12 +19,13 @@ | |||
| {% for ticket in user.tickets %} | |||
| <li class="{% if not ticket.active %}canceled{% endif %}"> | |||
| {% if ticket.timeplace %} | |||
| <a href="{% url 'timeplace_ticket_list' ticket.timeplace.event.pk ticket.timeplace.pk %}" target="_blank"> | |||
| <a href="{% url 'admin_time_place_ticket_list' ticket.timeplace.event.pk ticket.timeplace.pk %}" | |||
Check warning
Code scanning / CodeQL
Potentially unsafe external link
| @@ -38,21 +38,21 @@ | |||
| {% endif %} | |||
| </div> | |||
|
|
|||
| <a class="calendar-link" href="{% url 'timeplace_ical' news_obj.pk occurrence.pk %}" target="_blank"> | |||
| <a class="calendar-link" href="{% url 'time_place_ical' news_obj.pk occurrence.pk %}" target="_blank"> | |||
Check warning
Code scanning / CodeQL
Potentially unsafe external link
|
|
||
| <div class="time-place content"> | ||
| <a class="calendar-button" href="{% url 'timeplace_ical' time_place.event.pk time_place.pk %}" target="_blank"> | ||
| <a class="calendar-button" href="{% url 'time_place_ical' time_place.event.pk time_place.pk %}" target="_blank"> |
Check warning
Code scanning / CodeQL
Potentially unsafe external link
|
Regarding the Code Climate status check, I set it up recently on their website, but it seems like it maybe needs some tweaking 🤔 Anyway, none of the issues it lists are actually caused by changes in this PR, as things have simply been renamed/moved, so I will ignore them for this PR. |
|
Merging without explicit approval from another member, as the Dev committee previously agreed to merge these changes and assume they're relatively bug-free, simply to get things done quicker. |
Proposed changes
Improvements
Other changes
names of paths (84cc6b3), forms (3486ad8) and templates (4f19eb4) to comply with the style guidesIndexViewtoIndexPageView, and its pathnamefromfront_pagetoindex_page(e8320f4)Areas to review closely
References to the renamed code that I might have forgotten to update.
Checklist
(If any of the points are not relevant, mark them as checked)