Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't make a new connection #7

Closed
PlaidDroid opened this issue Jul 6, 2020 · 7 comments
Closed

Can't make a new connection #7

PlaidDroid opened this issue Jul 6, 2020 · 7 comments

Comments

@PlaidDroid
Copy link
Contributor

PlaidDroid commented Jul 6, 2020

aioi-bug

With all the connections removed, there was no way of making a new one!
OS: Ubuntu 20.04

This was the message that got printed when I clicked a lot:
[22249:0707/002742.995413:ERROR:buffer_manager.cc(488)] [.DisplayCompositor]GL ERROR :GL_INVALID_OPERATION : glBufferData: <- error from previous GL command

@PlaidDroid
Copy link
Contributor Author

[ Temporary Fix: ]

  • Delete the aioi folder in ~/.config
  • Start the application again

@ashugeo
Copy link
Collaborator

ashugeo commented Aug 13, 2020

Thank you @PlaidDroid for this bug report 🙂

@MAKIO135 putting you on track, there's the following error at /desktop/js/ui.js:248:

Uncaught TypeError: Cannot read property 'ip' of undefined

lastHost is undefined here, so addHostLi() can't be run:

const lastHost = app.config.hosts[app.config.hosts.length - 1];
const newHost = {
    ip: lastHost.ip,
    port: lastHost.port + 1,
    type: lastHost.type,
    oscString: '',
    udpString: ''
 };

addHostLi(newHost);

@PlaidDroid
Copy link
Contributor Author

Well...this works, but I don't know if it will make a difference if let is used instead of const (Obviously const cannot be used here, in the following code) :

let newHost;

    if (app.config.hosts.length > 0) {
      const lastHost = app.config.hosts[app.config.hosts.length - 1];
      newHost = {
        ip: lastHost.ip,
        port: lastHost.port + 1,
        type: lastHost.type,
        oscString: "",
        udpString: "",
      };
    } else {
      newHost = {
        ip: "127.0.0.1",
        port: 8000,
        type: "osc",
        path: "/yo",
        oscString: "/yo 135 2.4 test",
      };
    }

    addHostLi(newHost);
    app.win.setContentSize(
      app.win.getContentSize()[0],
      addButton.getBoundingClientRect().bottom + 30
    );
  });

PlaidDroid added a commit to PlaidDroid/aioi that referenced this issue Aug 17, 2020
@MAKIO135
Copy link
Owner

Hey @PlaidDroid, catching up with the issue. Thanks for your solution.
I might also consider preventing the user to delete the last host, what would you think about this solution ?

@PlaidDroid
Copy link
Contributor Author

Yes yes that's perfect! That makes more sense.

@ashugeo
Copy link
Collaborator

ashugeo commented Aug 17, 2020

I might also consider preventing the user to delete the last host, what would you think about this solution ?

My 2 cents @MAKIO135: UX-wise, I think we (almost) always should let users delete what they want to delete 🙂 I reckon it's ok to empty the interface, so as to populate it again. What do you think?

MAKIO135 added a commit that referenced this issue Aug 18, 2020
@MAKIO135
Copy link
Owner

@PlaidDroid: following @ashugeo's advice, I ended with your solution 🙏.
Updated the OSX/Linux releases.
Need to build Win release on my Win machine, coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants