Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#286) Fix multiplication when the second input(Y) is negative. #287

Merged
merged 2 commits into from
Jun 9, 2020
Merged

(#286) Fix multiplication when the second input(Y) is negative. #287

merged 2 commits into from
Jun 9, 2020

Conversation

kishorliv
Copy link
Contributor

This PR solves this issue #286 .

  • If the second input is negative:
    - Make that input positive and assign counter that value.
    - Set negflag to one.
  • When the addition is done in the loop, check for negflag:
    - If set, make the result(num) negative and halt
    - else, halt

@kishorliv kishorliv mentioned this pull request Jun 8, 2020
Closed
@auroranil auroranil merged commit 20c6503 into MARIE-js:master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@auroranil auroranil auroranil approved these changes

@cyderize cyderize Awaiting requested review from cyderize cyderize is a code owner

@ericjiang97 ericjiang97 Awaiting requested review from ericjiang97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kishorliv @auroranil