Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow integer overflow #328

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Allow integer overflow #328

merged 1 commit into from
Feb 18, 2024

Conversation

PowerkadDev
Copy link
Contributor

Adding two numbers with a sum outside the range of representable numbers in two's complement results in an error, when it would be more accurate and useful to allow the number to overflow and change sign.

Copy link
Member

@auroranil auroranil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@auroranil auroranil merged commit 2f18c7e into MARIE-js:master Feb 18, 2024
@auroranil auroranil mentioned this pull request Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants