-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for CollateralToken and ERC20 #17
Tests for CollateralToken and ERC20 #17
Conversation
@kelvintyb -- Any update on this? Let me know if you need any help in case you're stuck. Also looks like there are some conflicts. Please do rebase your branch with that of |
Thanks @eswarasai, will reach out if I get stuck, this week is looking busy at work, but I will be able to work on this more over the weekend. Sorry about the delay! |
@kelvintyb -- Sure. No problem. Let us know once it's ready for review. Thanks :) |
WIP update: Added more tests for methods on CollateralToken, and adjusted variables tests. |
@kelvintyb -- Thanks for the update. Let us know when the PR is ready for the review. Also please do rebase your branch with |
072131a
to
b5bf7fc
Compare
@eswarasai rebased my branch on the latest upstream:develop; PR is ready for review. |
@kelvintyb -- Can you please remove the |
Yep, done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@kelvintyb -- I've just merged the PR. Just a heads up on the other issue you'd be tackling. So the methods |
Description
Add specs for CollateralToken and ERC20
Checklist
Refers/Fixes
Fixes: #3
Fixes: #4