Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Add Windows Qt5 Build, Update GH Actions & Fix macos build errors. #139

Closed
wants to merge 3 commits into from

Conversation

HotaruBlaze
Copy link
Contributor

This adds a fallback Qt5 windows build, as on rare instances Qt6 does not work correctly on windows, Using Qt5 suffers from small UI differences, such as the titlebar not matching the windows theme, however is functionally the same.

image


This also cleans up the actions.yml such as

Before:

image


After:

image

@HotaruBlaze HotaruBlaze marked this pull request as ready for review April 29, 2024 21:33
@HotaruBlaze HotaruBlaze marked this pull request as draft April 29, 2024 21:42
@HotaruBlaze HotaruBlaze marked this pull request as ready for review May 3, 2024 02:39
@HotaruBlaze HotaruBlaze marked this pull request as draft May 8, 2024 18:31
@HotaruBlaze
Copy link
Contributor Author

This has been set back to draft because Universal2 builds are now broken due to the latest GH macos update

image

Co-Authored-By: Spotlight <spotlight@joscomputing.space>
@HotaruBlaze
Copy link
Contributor Author

MacOS issues have been fixed with the help of @spotlightishere

@HotaruBlaze HotaruBlaze marked this pull request as ready for review May 8, 2024 18:58
@HotaruBlaze HotaruBlaze changed the title [Github] Add Windows Qt5 Build & Update GH Actions [Github] Add Windows Qt5 Build, Update GH Actions & Fix macos build errors. May 8, 2024
@HotaruBlaze
Copy link
Contributor Author

Superseded by #147

@HotaruBlaze HotaruBlaze deleted the update-actions branch May 15, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant