Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review exercise: Shu Wang #117

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Code review exercise: Shu Wang #117

wants to merge 19 commits into from

Commits on Jan 8, 2024

  1. Refactor uncommunicative names

    @shugewang
    shugewang committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    ebb5907 View commit details
    Browse the repository at this point in the history

  2. Refactor duplicate code

    @shugewang
    shugewang committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    d7ab82e View commit details
    Browse the repository at this point in the history

  3. refactor: extract variable

    @shugewang
    shugewang committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    b569ce6 View commit details
    Browse the repository at this point in the history

  4. refactor duplicate code

    @shugewang
    shugewang committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    2a27577 View commit details
    Browse the repository at this point in the history

  5. refactor: extract magic number

    @shugewang
    shugewang committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    7ae182e View commit details
    Browse the repository at this point in the history

  6. rename constants

    @shugewang
    shugewang committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    26a68c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. refactor: extract addCoin(), updateCurrentPlayer() and shouldGameCont… 

    …inue() into one method
    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    88a2dfb View commit details
    Browse the repository at this point in the history

  2. refactor: decompose conditional

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    e537779 View commit details
    Browse the repository at this point in the history

  3. refactor: extract isRollOdd as method instead of variable

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6a22b6e View commit details
    Browse the repository at this point in the history

  4. refactor: extract Board, Player and Place classes

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    eaa7546 View commit details
    Browse the repository at this point in the history

  5. refactor: take places out of Game class

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    bcc7d75 View commit details
    Browse the repository at this point in the history

  6. refactor: extract places property to Player class as position

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    cf77463 View commit details
    Browse the repository at this point in the history

  7. remove now unused getNumberOfPlayers() method

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    670336b View commit details
    Browse the repository at this point in the history

  8. refactor: changed currentCategory() to be less coupled to Game class

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    35dc3e2 View commit details
    Browse the repository at this point in the history

  9. refactor: move question category logic to Place class

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    99037f7 View commit details
    Browse the repository at this point in the history

  10. refactor: extract questions to QuestionBank class

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    99f5aa5 View commit details
    Browse the repository at this point in the history

  11. refactor: convert string concat to template, split updateRoundAndChec… 

    …kIfShouldContinue() into separate methods
    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    4b3388f View commit details
    Browse the repository at this point in the history

  12. refactor: extract currentPlayer into field on Game class

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    6c66990 View commit details
    Browse the repository at this point in the history

  13. refactor: move askQuestion() into QuestionBank class

    @shugewang
    shugewang committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    5aa2121 View commit details
    Browse the repository at this point in the history