-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code review exercise: Shu Wang #117
Open
shugewang
wants to merge
19
commits into
MCR-Digital:master
Choose a base branch
from
shugewang:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Jan 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ebb5907 - Browse repository at this point
Copy the full SHA ebb5907View commit details -
Configuration menu - View commit details
-
Copy full SHA for d7ab82e - Browse repository at this point
Copy the full SHA d7ab82eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b569ce6 - Browse repository at this point
Copy the full SHA b569ce6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a27577 - Browse repository at this point
Copy the full SHA 2a27577View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7ae182e - Browse repository at this point
Copy the full SHA 7ae182eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 26a68c3 - Browse repository at this point
Copy the full SHA 26a68c3View commit details
Commits on Jan 9, 2024
-
refactor: extract addCoin(), updateCurrentPlayer() and shouldGameCont…
…inue() into one method
Configuration menu - View commit details
-
Copy full SHA for 88a2dfb - Browse repository at this point
Copy the full SHA 88a2dfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for e537779 - Browse repository at this point
Copy the full SHA e537779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a22b6e - Browse repository at this point
Copy the full SHA 6a22b6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for eaa7546 - Browse repository at this point
Copy the full SHA eaa7546View commit details -
Configuration menu - View commit details
-
Copy full SHA for bcc7d75 - Browse repository at this point
Copy the full SHA bcc7d75View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf77463 - Browse repository at this point
Copy the full SHA cf77463View commit details -
Configuration menu - View commit details
-
Copy full SHA for 670336b - Browse repository at this point
Copy the full SHA 670336bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 35dc3e2 - Browse repository at this point
Copy the full SHA 35dc3e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99037f7 - Browse repository at this point
Copy the full SHA 99037f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99f5aa5 - Browse repository at this point
Copy the full SHA 99f5aa5View commit details -
refactor: convert string concat to template, split updateRoundAndChec…
…kIfShouldContinue() into separate methods
Configuration menu - View commit details
-
Copy full SHA for 4b3388f - Browse repository at this point
Copy the full SHA 4b3388fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c66990 - Browse repository at this point
Copy the full SHA 6c66990View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5aa2121 - Browse repository at this point
Copy the full SHA 5aa2121View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.