Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Affected by fortune" checkbox under loot tables is not working #507

Closed
BreezeM4n opened this issue Nov 9, 2020 · 9 comments
Closed

"Affected by fortune" checkbox under loot tables is not working #507

BreezeM4n opened this issue Nov 9, 2020 · 9 comments
Assignees
@KlemenDEV
Labels
bug Something isn't working
Milestone
2020.5 full release

Comments

@BreezeM4n
Copy link

Hello Dear Mcreator Team,

When I was making a mod, I created a ore and made a loot table for it.
The loot table I made for my ore drops ore itself with silktouch and should drop more "gemstones" with fortune. I have ticked "affected by fortune" in the pool of the ore but the ore is not affected by fortune at all!

There isnt anything special about the ore, just a block which can be generated in the overworld
@BreezeM4n BreezeM4n added the bug Something isn't working label Nov 9, 2020
@Goldorion
Copy link
Collaborator

Please follow the bug report template and give more details.

@Goldorion Goldorion added invalid Issue does not follow the tracker rules more information needed The issue opener needs to provide more information labels Nov 9, 2020
@KlemenDEV
Copy link
Contributor

As already instructed, follow the template and also provide a minimal reproducible example.

@BreezeM4n
Copy link
Author

The minimal reproducible example I can give is this:

I have created a ore and a item

I made a new loot table for the ore and I added 2 entries to the pool. one of them is ore itself with "only with silktouch" checked
the other one was the "item" dropped by block when mined normally. I checked "affected by fortune" tick box. When I broke the blocks with a fortune 3 pickaxe they just dropped 1 item each. This is in 2020.5 (43719)

@no-response no-response bot removed the more information needed The issue opener needs to provide more information label Nov 9, 2020
@KlemenDEV
Copy link
Contributor

Make a minimal reproducible workspace and attach it here.

@KlemenDEV KlemenDEV added the more information needed The issue opener needs to provide more information label Nov 9, 2020
@BreezeM4n
Copy link
Author

fortuneloottabletestmod.zip

@no-response no-response bot removed the more information needed The issue opener needs to provide more information label Nov 10, 2020
@KlemenDEV KlemenDEV self-assigned this Nov 10, 2020
@KlemenDEV
Copy link
Contributor

I tested your workspace and silk touch works. Keep in mind in your test world, you used fortune enchanted pickaxe, not silk touch enchanted pickaxe.

This is not how Minecraft silk touch works. You need silk touch enchantment on your pickaxe to do silk touch drops.

@KlemenDEV KlemenDEV added this to the 2020.5 full release milestone Nov 10, 2020
@BreezeM4n
Copy link
Author

The issue here was not the silk touch it works as intended, drops ore itself when used with a silk touch pickaxe

The issue here is fortune is not affecting the loot table at all, I broke 16 blocks in the specific workspace I sent, and each of them dropped just 1 "drop" (with a diamond pickaxe enchanetd with fortune 3).

@KlemenDEV KlemenDEV reopened this Nov 10, 2020
@KlemenDEV
Copy link
Contributor

KlemenDEV commented Nov 10, 2020 •
edited

Sorry, my bad, reopened.

@KlemenDEV
Copy link
Contributor

I can indeed confirm this, I will look into it.

@KlemenDEV KlemenDEV removed the invalid Issue does not follow the tracker rules label Nov 10, 2020
KlemenDEV added a commit that referenced this issue Nov 27, 2020
@Goldorion @KlemenDEV
@MysteriousWolf @Defeatomizer
Forge 1.16.4 - Food mod element (#555)
5c19ca3 
* update (#16)

* Improved help tip to resolve confusion as appeared in https://mcreator.net/forum/67868/act-ladders-not-working

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Updated some dependencies to fix some bugs in the used libs and improve stability

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (French) (#510)

* Fix stamp tool offset.

* Externalized Blockly panels components and reorganized some strings (#495)

* Externalized CompileNotesPanel

* Externalized default trigger

* Removed duplicate intro comment from ProcedureTemplateDropdown

* Externalized AITasksEditorToolbar

* Externalized ProcedureEditorToolbar

* Added new keys and reorganized some existing strings

* Added new strings

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>

* Clarified xp result (MCreator/Generator-Forge-1.12.2#20)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#512)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (German)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* Fixed #507 ("Affected by fortune" checkbox under loot tables is not working) + improved loot table tests

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New texture templates (#514)

* Code reformat, fixed one wrong externalization use case

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#517)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* New Crowdin updates (#524)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (German)

* New translations texts.properties (Vietnamese) (#527)

* New translations texts.properties (French) (#533)

* New translations texts.properties (Polish) (#536)

* Fixed #535

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Removed help button that appeared in procedure editor after Blockly update (Fixes #538)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Fixed datalist mistake

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (Vietnamese) (#541)

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Matej <matej2000@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>

* Added food mod element

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Matej <matej2000@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>
KlemenDEV added a commit that referenced this issue Nov 30, 2020
@MysteriousWolf @Goldorion
@KlemenDEV @Defeatomizer
Recovery of smithing recipe support (#585)
b947dc1 
* update (#16)

* Improved help tip to resolve confusion as appeared in https://mcreator.net/forum/67868/act-ladders-not-working

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Updated some dependencies to fix some bugs in the used libs and improve stability

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (French) (#510)

* Fix stamp tool offset.

* Externalized Blockly panels components and reorganized some strings (#495)

* Externalized CompileNotesPanel

* Externalized default trigger

* Removed duplicate intro comment from ProcedureTemplateDropdown

* Externalized AITasksEditorToolbar

* Externalized ProcedureEditorToolbar

* Added new keys and reorganized some existing strings

* Added new strings

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>

* Clarified xp result (MCreator/Generator-Forge-1.12.2#20)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#512)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (German)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* Fixed #507 ("Affected by fortune" checkbox under loot tables is not working) + improved loot table tests

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New texture templates (#514)

* Code reformat, fixed one wrong externalization use case

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#517)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* New Crowdin updates (#524)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (German)

* New translations texts.properties (Vietnamese) (#527)

* New translations texts.properties (French) (#533)

* New translations texts.properties (Polish) (#536)

* Fixed #535

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Removed help button that appeared in procedure editor after Blockly update (Fixes #538)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Fixed datalist mistake

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (Vietnamese) (#541)

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Matej <matej2000@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>

* Implemented recipes for data packs + Added smithing recipe

* Added the image for the smithing recipes

* Added the translation text for the error

* Removed the mapping file

* Update TestWorkspaceDataProvider.java

* Added a test for the smithing recipe type

* Fixed typo

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Added smithing to 1.16.4

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Fixed a mistake causing unit test failures

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Improve smithing user intergace and previews

Co-authored-by: Goldorion <38427877+Goldorion@users.noreply.github.com>
Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>
Co-authored-by: Goldorion <toutankamon@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KlemenDEV KlemenDEV

Labels
bug Something isn't working
Projects
None yet
Milestone
2020.5 full release
Development

No branches or pull requests
3 participants
@KlemenDEV @Goldorion @BreezeM4n