Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conflict With Rideable Option And Entity Inventory #535

Closed
makcccc opened this issue Nov 17, 2020 · 1 comment
Closed

Conflict With Rideable Option And Entity Inventory #535

makcccc opened this issue Nov 17, 2020 · 1 comment
Assignees
@KlemenDEV
Labels
bug Something isn't working
Milestone
2020.5 full release

Comments

@makcccc
Copy link

makcccc commented Nov 17, 2020 •
edited

Describe the bug

Whenever i tried to use rideable option and Bind GUI to same mob. This error occurs

Steps To Reproduce

Create Mob With Rideable option on and also bind inventory(GUI) to the same mob

Entity Generator

image

Details

  • MCreator version: [2020.5]
  • Generator type: [1.14.4]
  • OS: [Windows]

Minimal reproducible example workspace

bugreport1.zip

Logs

https://pastebin.com/cCsMENj9

Additional context

maybe is it because of overlap? (inventory and ride both uses rightclick)
maybe this could be solved if it was overlap. by have a extra option in rideable option (shift and rightclick to ride or shit and rightclick to open GUI)
so it won't conflicts
i dont know coding so i cant say so much but i hope this will be fixed or maybe is it already reported?
@makcccc makcccc added the bug Something isn't working label Nov 17, 2020
@KlemenDEV KlemenDEV added this to the 2020.5 full release milestone Nov 17, 2020
@KlemenDEV KlemenDEV self-assigned this Nov 17, 2020
@KlemenDEV
Copy link
Contributor

KlemenDEV commented Nov 17, 2020 •
edited

I can confirm this. I will look into this.

Note: this bug is not present in 1.15.2 generator.

KlemenDEV added a commit that referenced this issue Nov 27, 2020
@Goldorion @KlemenDEV
@MysteriousWolf @Defeatomizer
Forge 1.16.4 - Food mod element (#555)
5c19ca3 
* update (#16)

* Improved help tip to resolve confusion as appeared in https://mcreator.net/forum/67868/act-ladders-not-working

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Updated some dependencies to fix some bugs in the used libs and improve stability

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (French) (#510)

* Fix stamp tool offset.

* Externalized Blockly panels components and reorganized some strings (#495)

* Externalized CompileNotesPanel

* Externalized default trigger

* Removed duplicate intro comment from ProcedureTemplateDropdown

* Externalized AITasksEditorToolbar

* Externalized ProcedureEditorToolbar

* Added new keys and reorganized some existing strings

* Added new strings

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>

* Clarified xp result (MCreator/Generator-Forge-1.12.2#20)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#512)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (German)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* Fixed #507 ("Affected by fortune" checkbox under loot tables is not working) + improved loot table tests

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New texture templates (#514)

* Code reformat, fixed one wrong externalization use case

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#517)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* New Crowdin updates (#524)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (German)

* New translations texts.properties (Vietnamese) (#527)

* New translations texts.properties (French) (#533)

* New translations texts.properties (Polish) (#536)

* Fixed #535

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Removed help button that appeared in procedure editor after Blockly update (Fixes #538)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Fixed datalist mistake

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (Vietnamese) (#541)

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Matej <matej2000@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>

* Added food mod element

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Matej <matej2000@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>
KlemenDEV added a commit that referenced this issue Nov 30, 2020
@MysteriousWolf @Goldorion
@KlemenDEV @Defeatomizer
Recovery of smithing recipe support (#585)
b947dc1 
* update (#16)

* Improved help tip to resolve confusion as appeared in https://mcreator.net/forum/67868/act-ladders-not-working

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Updated some dependencies to fix some bugs in the used libs and improve stability

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (French) (#510)

* Fix stamp tool offset.

* Externalized Blockly panels components and reorganized some strings (#495)

* Externalized CompileNotesPanel

* Externalized default trigger

* Removed duplicate intro comment from ProcedureTemplateDropdown

* Externalized AITasksEditorToolbar

* Externalized ProcedureEditorToolbar

* Added new keys and reorganized some existing strings

* Added new strings

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>

* Clarified xp result (MCreator/Generator-Forge-1.12.2#20)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#512)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (German)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* Fixed #507 ("Affected by fortune" checkbox under loot tables is not working) + improved loot table tests

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New texture templates (#514)

* Code reformat, fixed one wrong externalization use case

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New Crowdin updates (#517)

* New translations texts.properties (French)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (Chinese Simplified)

* New translations texts.properties (Chinese Traditional)

* New translations texts.properties (Russian)

* New translations texts.properties (Vietnamese)

* New translations texts.properties (Polish)

* New Crowdin updates (#524)

* New translations texts.properties (Portuguese, Brazilian)

* New translations texts.properties (German)

* New translations texts.properties (Vietnamese) (#527)

* New translations texts.properties (French) (#533)

* New translations texts.properties (Polish) (#536)

* Fixed #535

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Removed help button that appeared in procedure editor after Blockly update (Fixes #538)

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Fixed datalist mistake

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* New translations texts.properties (Vietnamese) (#541)

Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Matej <matej2000@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>

* Implemented recipes for data packs + Added smithing recipe

* Added the image for the smithing recipes

* Added the translation text for the error

* Removed the mapping file

* Update TestWorkspaceDataProvider.java

* Added a test for the smithing recipe type

* Fixed typo

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Added smithing to 1.16.4

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Fixed a mistake causing unit test failures

Signed-off-by: KlemenDEV <klemen.pylo@gmail.com>

* Improve smithing user intergace and previews

Co-authored-by: Goldorion <38427877+Goldorion@users.noreply.github.com>
Co-authored-by: KlemenDEV <klemen.pylo@gmail.com>
Co-authored-by: Defeatomizer <drag7398@gmail.com>
Co-authored-by: Goldorion <toutankamon@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KlemenDEV KlemenDEV

Labels
bug Something isn't working
Projects
None yet
Milestone
2020.5 full release
Development

No branches or pull requests
2 participants
@KlemenDEV @makcccc