-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20.4] Ported and ordered screens mapping #4623
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, but I think a few changes should be made to improve it.
Why do I have to realize something after I put the PR back to review 🤦♂️ |
I think we should add back the |
These have the same name in all generators? |
RFR in case yes. |
Would make sense to check, also if they are present in all of them |
I checked in online Forge Java documentation (local cache was erased when I was trying to resolve the JVMs-not-shutting-down thing), but I was sure my changes should be verified by one of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as 1.20.4 goes LGTM, check Klemen's comments for some small changes that are needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you :)
The order is now as follows:
Ingame
;MainMenu
andIngameMenu
;Tell me if this order should be further changed (or reverted).