Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.4] Ported and ordered screens mapping #4623

Merged
merged 7 commits into from
Feb 17, 2024

Conversation

Defeatomizer
Copy link
Collaborator

The order is now as follows:

  • Hard-coded default value of Ingame;
  • MainMenu and IngameMenu;
  • Block/entity/item interface screens, alphabetically sorted;
  • All other screens (not related to Realms), alphabetically sorted.

Tell me if this order should be further changed (or reverted).

Copy link
Collaborator

@MysteriousWolf MysteriousWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, but I think a few changes should be made to improve it.

@KlemenDEV KlemenDEV marked this pull request as draft February 16, 2024 10:51
@Defeatomizer Defeatomizer changed the title [1.20.4] Ported screens mapping [1.20.4] Ported and ordered screens mapping Feb 16, 2024
@Defeatomizer Defeatomizer marked this pull request as ready for review February 16, 2024 16:47
@Defeatomizer
Copy link
Collaborator Author

Why do I have to realize something after I put the PR back to review 🤦‍♂️

@KlemenDEV KlemenDEV removed their request for review February 16, 2024 19:39
@MysteriousWolf
Copy link
Collaborator

I think we should add back the GPUWarning: PopupScreen, as well as the other three missing screens (Realms32bitWarningScreen, DisconnectedRealmsScreen, and RealmsScreen), then I'll re-run the checker and we should be done.

@KlemenDEV KlemenDEV marked this pull request as draft February 17, 2024 15:39
@Defeatomizer
Copy link
Collaborator Author

These have the same name in all generators?

@Defeatomizer
Copy link
Collaborator Author

RFR in case yes.

@KlemenDEV
Copy link
Contributor

These have the same name in all generators?

Would make sense to check, also if they are present in all of them

@Defeatomizer
Copy link
Collaborator Author

I checked in online Forge Java documentation (local cache was erased when I was trying to resolve the JVMs-not-shutting-down thing), but I was sure my changes should be verified by one of you.

@KlemenDEV KlemenDEV marked this pull request as ready for review February 17, 2024 19:31
@KlemenDEV KlemenDEV marked this pull request as draft February 17, 2024 19:47
MysteriousWolf
MysteriousWolf previously approved these changes Feb 17, 2024
Copy link
Collaborator

@MysteriousWolf MysteriousWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as 1.20.4 goes LGTM, check Klemen's comments for some small changes that are needed.

@Defeatomizer Defeatomizer marked this pull request as ready for review February 17, 2024 19:51
Copy link
Collaborator

@MysteriousWolf MysteriousWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you :)

@MysteriousWolf MysteriousWolf merged commit 1135ac7 into MCreator:master Feb 17, 2024
2 checks passed
@Defeatomizer Defeatomizer deleted the 1.20.4/screens branch February 17, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants