-
-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.20.6] Ported Screens datalist #4849
Conversation
What did you base the ordering on here, since there is no particular file for screens? |
I ordered them based on who came first (file) |
Example: net.minecraft.client.gui.components.PopupScreen comes before net.minecraft.client.gui.screens.achievement.StatsScreen |
The order of 1.20.4 mappings was suggested by me on #4623 so that it is more/less sorted and at the same time minimally categorized. |
In this case it may make sense to keep the order of @Defeatomizer |
Ok :( |
It may help to explain the order idea @Defeatomizer |
The first category is 3 "main" screens of the game:
Next we have screens rendered above the one identified by
And then there are all the other screens found in MC:
Basically a lot of screens are used inside game worlds, and I thought splitting the data list by this almost boolean criterion only does not make the order complex enough to get lost in it. |
|
||
#LEGACY | ||
Realms32bitWarning: WarningScreen |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a very specific one, I would say you can safely remove it (also from datalist and old mappings)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Reordered and Ported Screens Mapping