-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strict python minimum version for install (Issue #112) and auto-deployment via actions #113
Conversation
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=======================================
Coverage 87.56% 87.56%
=======================================
Files 5 5
Lines 748 748
Branches 133 133
=======================================
Hits 655 655
Misses 56 56
Partials 37 37 Continue to review full report at Codecov.
|
@@ -0,0 +1,57 @@ | |||
name: Build and upload to PyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pypa has some really good docs on this, it was a surprising experience: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
This will run a build runner every time we push/PR, and also whenever there's a release. If we push a new tag it will upload the build to testpypi for us to check before a release, if we pusblish a release it'll be automatically pushed to pypi.
What needs to be done here is:
- Uploading the relevant github secret API tokens for testpypi and pypi.
- Checking that the testpypi upload works (create a fake tag for an alpha version of 1.0.1 upload it and then delete the tag?)
- Checking that the pypi upload works on publication of the next release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good (as in the PyPI docs).
I don't have a TestPyPI account. Can you set up the TestPyPI repo and the secrets?
@IAlibay I invited you as owner on PyPi for gdf |
thanks, is there a testpypi project too? |
Will you be able to check the new workflow once you have accepted ownership of gdf or do you need me to do something here? |
No, there's no testpypi. |
Yeah I'll need to create a testpypi version but that should be fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, as far as I can tell. Thank you for modernizing!
|
||
* Setup is now solely possible using python 3.8 and above. | ||
* Deployment is now automatically done using github actions. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there be a "Fixes" that indicates that 1.0.0 could fail to install if it was incorrectly attempted in a 2.7 or <3.8 environment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure I can swap that first bullet point to a fixes entry.
@@ -0,0 +1,57 @@ | |||
name: Build and upload to PyPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good (as in the PyPI docs).
I don't have a TestPyPI account. Can you set up the TestPyPI repo and the secrets?
Ok I've removed the requirement to review the build action because otherwise this will never end. Everything seems to work right now, I just need to create the 1.0.1 release tag and see if testpypi likes it. |
Add
python_requires
, dropsuniversal
entry for wheel generation (note we probably should clean that out of the core repo's setup.cfg too...)To do: