Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves inheritance of Grid #63

Merged
merged 3 commits into from Apr 6, 2019
Merged

improves inheritance of Grid #63

merged 3 commits into from Apr 6, 2019

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Apr 6, 2019

fixes issue #56

  • arithmetic operations on Grids now properly return an object of its own class (and not just Grid)
  • input arrays retain their subclass of ndarray (e.g., MaskedArray)

- use suggestion by @AstroMike in #56
- add test for using a DerivedClass
- uses solution proposed by @AstroMike (np.asanyarray())
- fix #56
- add test (with np.ma.MaskedArray)
- update CHANGELOG
@codecov
Copy link

codecov bot commented Apr 6, 2019

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   85.15%   85.15%           
=======================================
  Files           5        5           
  Lines         761      761           
  Branches      108      108           
=======================================
  Hits          648      648           
  Misses         70       70           
  Partials       43       43
Impacted Files Coverage Δ
gridData/core.py 88.75% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7e3b83...04dcbc1. Read the comment docs.

@orbeckst orbeckst merged commit 6c47ad6 into master Apr 6, 2019
@orbeckst orbeckst deleted the subclassing-56 branch April 6, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant