-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made python 3 support official #1524
Conversation
I need to go through and check where we state that we don't support py3 |
For the build matrix failures, I think we've been starting to see these a bit more (randomly?) now:
There's an associated discussion on the pytest github, which then broke out to an xdist issue. Is this serious enough to warrant removing the parallel testing for now? We need reproducible CI test results and cycles are currently slow / expensive / etc. Maybe a new issue needs to be opened for the discussion. |
Ok I disabled xdist for now, build times are about 30mins maximum, which is manageable for now. Should be good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. For the separate issue of the ignored exception in the 3.4/3.5 rows of the build matrix, see #1530.
Perhaps I'll allow another @MDAnalysis/coredevs to merge, given the impact of changing the Travis build matrix & need for agreement, etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardjgowers because this PR changes the CHANGELOG with the momentous entry "we support Py 3 now", I would also like the same PR remove any of the "Py 3 is experimental" warnings as well as updates to the docs that clearly state what we're supporting; In #1446 we got the justified complaint that our docs are not clear on what we support.
@orbeckst that notice is already killed |
Because the request changes were done elsewhere.
Fixes #260
Changes made in this Pull Request:
PR Checklist