Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates hole download links #1798

Merged
merged 1 commit into from
Mar 5, 2018

Conversation

palnabarun
Copy link
Member

@palnabarun palnabarun commented Mar 5, 2018

Fixes #1792

Changes made in this Pull Request:

  • Now uses the holeprogram.org download links

This is a temporary fix. We can use the longterm solution mentioned here (#1429) when it is ready.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Now uses the holeprogram.org download links
Fixes MDAnalysis#1792
@richardjgowers richardjgowers merged commit e97fd8e into MDAnalysis:develop Mar 5, 2018
@richardjgowers
Copy link
Member

Cool thanks @palnabarun

@mimischi
Copy link
Contributor

mimischi commented Mar 5, 2018

One comment on this: the DOWNLOAD_URL now points to a http:// link instead of https://, the former should be not be used when possible. https://www.holeprogram.org seems to work and provides a valid SSL certificate.

@palnabarun
Copy link
Member Author

@mimischi I agree to that. Let me create an issue and file a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update HOLE distribution URL for test installation
3 participants