Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: update Cython imports #3468

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

tylerjereddy
Copy link
Member

  • use np.import_array() to prevent convoluted issues with
    newer versions of Cython when using cimport numpy .. in
    Cython sources

  • in short, Cython and NumPy try to coordinate to do the right
    thing with interwoven header inclusions, but this explicit call
    prevents any confusion between the two

Fixes #3455

Changes made in this Pull Request:

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

* use `np.import_array()` to prevent convoluted issues with
newer versions of Cython when using `cimport numpy ..` in
Cython sources

* in short, Cython and NumPy try to coordinate to do the right
thing with interwoven header inclusions, but this explicit call
prevents any confusion between the two
@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #3468 (9490241) into develop (46c8bad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3468   +/-   ##
========================================
  Coverage    93.75%   93.75%           
========================================
  Files          176      176           
  Lines        23163    23169    +6     
  Branches      3297     3297           
========================================
+ Hits         21717    21723    +6     
  Misses        1395     1395           
  Partials        51       51           
Impacted Files Coverage Δ
package/MDAnalysis/lib/_augment.pyx 100.00% <100.00%> (ø)
package/MDAnalysis/lib/_cutil.pyx 100.00% <100.00%> (ø)
package/MDAnalysis/lib/c_distances.pyx 100.00% <100.00%> (ø)
package/MDAnalysis/lib/c_distances_openmp.pyx 100.00% <100.00%> (ø)
package/MDAnalysis/lib/formats/libdcd.pyx 88.53% <100.00%> (+0.04%) ⬆️
package/MDAnalysis/lib/qcprot.pyx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c8bad...9490241. Read the comment docs.

Copy link
Member

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardjgowers richardjgowers merged commit 5bf6359 into MDAnalysis:develop Nov 30, 2021
@tylerjereddy tylerjereddy deleted the treddy_issue_3455 branch December 8, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: updating Cython imports
2 participants